Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix justification for button block when selected #33739

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jul 28, 2021

Description

When selecting the button block and applying a justification, the justify doesn't apply until the box is unselected.

What is really happening is when the block is unselected the block appender is removed, and the rules for the block appender is forcing the button all the way to the left so when removed it allows the justification to apply and the block is then centered (or right).

Fixes #33487

How has this been tested?

  1. Confirm bug by adding buttons block and justify center or right, see bug Buttons block: justification setting ignored when the block is selected #33487
  2. Unselect the block to see justification applied
  3. Apply PR fix
  4. Repeat and notice justification applies immediately

button-justify

Types of changes

This PR changes the block appender CSS rules that forced justified content all the way to the left. I did extra testing around but any additional checks are welcome to confirm no unintended consequences with the appender elsewhere.

@mkaz mkaz requested a review from ellatrix as a code owner July 28, 2021 23:40
@mkaz mkaz added the [Block] Buttons Affects the Buttons Block label Jul 28, 2021
@mkaz mkaz requested a review from jasmussen July 28, 2021 23:40
@github-actions
Copy link

github-actions bot commented Jul 28, 2021

Size Change: +1.59 kB (0%)

Total Size: 1.08 MB

Filename Size Change
build/api-fetch/index.min.js 2.44 kB +1 B (0%)
build/block-directory/style-rtl.css 1.01 kB -8 B (-1%)
build/block-directory/style.css 1.01 kB -9 B (-1%)
build/block-editor/index.min.js 127 kB +115 B (0%)
build/block-editor/style-rtl.css 13.9 kB -156 B (-1%)
build/block-editor/style.css 13.8 kB -161 B (-1%)
build/block-library/blocks/audio/style-rtl.css 111 B -1 B (-1%)
build/block-library/blocks/audio/style.css 111 B -1 B (-1%)
build/block-library/blocks/button/editor-rtl.css 474 B -1 B (0%)
build/block-library/blocks/button/style-rtl.css 605 B +2 B (0%)
build/block-library/blocks/button/style.css 604 B +2 B (0%)
build/block-library/blocks/buttons/style-rtl.css 370 B -5 B (-1%)
build/block-library/blocks/buttons/style.css 370 B -5 B (-1%)
build/block-library/blocks/calendar/style-rtl.css 207 B -1 B (0%)
build/block-library/blocks/calendar/style.css 207 B -1 B (0%)
build/block-library/blocks/columns/editor-rtl.css 189 B -1 B (-1%)
build/block-library/blocks/columns/editor.css 188 B -2 B (-1%)
build/block-library/blocks/columns/style-rtl.css 474 B -1 B (0%)
build/block-library/blocks/columns/style.css 475 B -1 B (0%)
build/block-library/blocks/cover/editor-rtl.css 666 B -4 B (-1%)
build/block-library/blocks/cover/style-rtl.css 1.23 kB +3 B (0%)
build/block-library/blocks/cover/style.css 1.23 kB +2 B (0%)
build/block-library/blocks/embed/editor-rtl.css 488 B +2 B (0%)
build/block-library/blocks/embed/editor.css 488 B +2 B (0%)
build/block-library/blocks/embed/style-rtl.css 400 B -1 B (0%)
build/block-library/blocks/file/editor-rtl.css 300 B -1 B (0%)
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB -4 B (0%)
build/block-library/blocks/freeform/editor.css 2.44 kB -5 B (0%)
build/block-library/blocks/gallery/editor-rtl.css 707 B +3 B (0%)
build/block-library/blocks/gallery/editor.css 706 B +1 B (0%)
build/block-library/blocks/gallery/style-rtl.css 1.05 kB -7 B (-1%)
build/block-library/blocks/gallery/style.css 1.05 kB -7 B (-1%)
build/block-library/blocks/group/editor-rtl.css 159 B -1 B (-1%)
build/block-library/blocks/group/editor.css 159 B -1 B (-1%)
build/block-library/blocks/html/editor-rtl.css 283 B +2 B (+1%)
build/block-library/blocks/html/editor.css 284 B +3 B (+1%)
build/block-library/blocks/image/editor-rtl.css 728 B -1 B (0%)
build/block-library/blocks/image/editor.css 728 B +1 B (0%)
build/block-library/blocks/image/style-rtl.css 482 B +1 B (0%)
build/block-library/blocks/image/style.css 487 B +2 B (0%)
build/block-library/blocks/latest-comments/style-rtl.css 284 B -2 B (-1%)
build/block-library/blocks/latest-comments/style.css 284 B -2 B (-1%)
build/block-library/blocks/latest-posts/style-rtl.css 528 B +2 B (0%)
build/block-library/blocks/latest-posts/style.css 527 B +3 B (+1%)
build/block-library/blocks/media-text/editor-rtl.css 266 B +3 B (+1%)
build/block-library/blocks/media-text/editor.css 263 B -1 B (0%)
build/block-library/blocks/media-text/style-rtl.css 488 B -4 B (-1%)
build/block-library/blocks/media-text/style.css 485 B -4 B (-1%)
build/block-library/blocks/more/editor-rtl.css 431 B -3 B (-1%)
build/block-library/blocks/more/editor.css 431 B -3 B (-1%)
build/block-library/blocks/navigation-link/editor.css 474 B +1 B (0%)
build/block-library/blocks/navigation/editor-rtl.css 1.67 kB -16 B (-1%)
build/block-library/blocks/navigation/editor.css 1.68 kB -11 B (-1%)
build/block-library/blocks/navigation/style-rtl.css 1.65 kB -2 B (0%)
build/block-library/blocks/navigation/style.css 1.64 kB -20 B (-1%)
build/block-library/blocks/page-list/editor.css 310 B -1 B (0%)
build/block-library/blocks/page-list/style-rtl.css 242 B +2 B (+1%)
build/block-library/blocks/page-list/style.css 242 B +2 B (+1%)
build/block-library/blocks/paragraph/style-rtl.css 248 B +1 B (0%)
build/block-library/blocks/post-author/editor-rtl.css 210 B +1 B (0%)
build/block-library/blocks/post-author/editor.css 210 B +1 B (0%)
build/block-library/blocks/post-author/style-rtl.css 182 B -1 B (-1%)
build/block-library/blocks/post-author/style.css 181 B -3 B (-2%)
build/block-library/blocks/post-content/editor-rtl.css 138 B -1 B (-1%)
build/block-library/blocks/post-content/editor.css 138 B -1 B (-1%)
build/block-library/blocks/post-featured-image/editor-rtl.css 412 B +74 B (+22%) 🚨
build/block-library/blocks/post-featured-image/editor.css 412 B +74 B (+22%) 🚨
build/block-library/blocks/post-featured-image/style-rtl.css 143 B +2 B (+1%)
build/block-library/blocks/post-featured-image/style.css 143 B +2 B (+1%)
build/block-library/blocks/post-template/editor-rtl.css 99 B -1 B (-1%)
build/block-library/blocks/post-template/editor.css 98 B -1 B (-1%)
build/block-library/blocks/post-template/style-rtl.css 378 B -1 B (0%)
build/block-library/blocks/post-template/style.css 379 B -1 B (0%)
build/block-library/blocks/pullquote/style-rtl.css 361 B -1 B (0%)
build/block-library/blocks/pullquote/style.css 360 B -1 B (0%)
build/block-library/blocks/pullquote/theme-rtl.css 167 B -2 B (-1%)
build/block-library/blocks/pullquote/theme.css 167 B -2 B (-1%)
build/block-library/blocks/query-title/editor-rtl.css 85 B -1 B (-1%)
build/block-library/blocks/query-title/editor.css 85 B -1 B (-1%)
build/block-library/blocks/quote/theme-rtl.css 220 B -1 B (0%)
build/block-library/blocks/quote/theme.css 222 B +1 B (0%)
build/block-library/blocks/rss/editor-rtl.css 202 B +1 B (0%)
build/block-library/blocks/rss/editor.css 204 B +2 B (+1%)
build/block-library/blocks/rss/style-rtl.css 289 B -1 B (0%)
build/block-library/blocks/rss/style.css 288 B -2 B (-1%)
build/block-library/blocks/search/editor-rtl.css 209 B -2 B (-1%)
build/block-library/blocks/search/editor.css 209 B -2 B (-1%)
build/block-library/blocks/search/style-rtl.css 368 B -4 B (-1%)
build/block-library/blocks/search/style.css 372 B -1 B (0%)
build/block-library/blocks/separator/style-rtl.css 250 B -1 B (0%)
build/block-library/blocks/separator/style.css 250 B -1 B (0%)
build/block-library/blocks/shortcode/editor-rtl.css 474 B -2 B (0%)
build/block-library/blocks/shortcode/editor.css 474 B -2 B (0%)
build/block-library/blocks/site-logo/editor-rtl.css 462 B -3 B (-1%)
build/block-library/blocks/site-logo/editor.css 464 B -1 B (0%)
build/block-library/blocks/site-logo/style-rtl.css 153 B -1 B (-1%)
build/block-library/blocks/site-logo/style.css 153 B -1 B (-1%)
build/block-library/blocks/site-tagline/editor-rtl.css 86 B -1 B (-1%)
build/block-library/blocks/site-tagline/editor.css 86 B -1 B (-1%)
build/block-library/blocks/site-title/editor-rtl.css 84 B -1 B (-1%)
build/block-library/blocks/site-title/editor.css 84 B -1 B (-1%)
build/block-library/blocks/social-link/editor-rtl.css 165 B +1 B (+1%)
build/block-library/blocks/social-links/editor-rtl.css 812 B +12 B (+2%)
build/block-library/blocks/social-links/editor.css 811 B +12 B (+2%)
build/block-library/blocks/social-links/style-rtl.css 1.33 kB -2 B (0%)
build/block-library/blocks/social-links/style.css 1.33 kB -4 B (0%)
build/block-library/blocks/spacer/editor-rtl.css 307 B -1 B (0%)
build/block-library/blocks/spacer/editor.css 307 B -1 B (0%)
build/block-library/blocks/table/editor-rtl.css 471 B -7 B (-1%)
build/block-library/blocks/table/editor.css 472 B -6 B (-1%)
build/block-library/blocks/table/style-rtl.css 481 B +1 B (0%)
build/block-library/blocks/table/style.css 481 B +1 B (0%)
build/block-library/blocks/template-part/editor-rtl.css 636 B +85 B (+15%) ⚠️
build/block-library/blocks/template-part/editor.css 635 B +85 B (+15%) ⚠️
build/block-library/blocks/video/editor-rtl.css 571 B +2 B (0%)
build/block-library/blocks/video/editor.css 572 B +2 B (0%)
build/block-library/common-rtl.css 1.29 kB +3 B (0%)
build/block-library/common.css 1.29 kB +2 B (0%)
build/block-library/editor-rtl.css 9.87 kB +34 B (0%)
build/block-library/editor.css 9.85 kB +17 B (0%)
build/block-library/index.min.js 147 kB +792 B (+1%)
build/block-library/reset.css 514 B -1 B (0%)
build/block-library/style-rtl.css 10.2 kB -69 B (-1%)
build/block-library/style.css 10.2 kB -65 B (-1%)
build/block-library/theme-rtl.css 688 B -4 B (-1%)
build/block-library/theme.css 692 B -1 B (0%)
build/blocks/index.min.js 47.2 kB -2 B (0%)
build/components/index.min.js 197 kB +705 B (0%)
build/components/style-rtl.css 15.8 kB -165 B (-1%)
build/components/style.css 15.8 kB -151 B (-1%)
build/core-data/index.min.js 12.6 kB +114 B (+1%)
build/customize-widgets/index.min.js 10.8 kB +438 B (+4%)
build/customize-widgets/style-rtl.css 1.5 kB +11 B (+1%)
build/customize-widgets/style.css 1.49 kB +10 B (+1%)
build/data/index.min.js 7.22 kB +1 B (0%)
build/edit-navigation/index.min.js 13.9 kB +3 B (0%)
build/edit-navigation/style-rtl.css 3.1 kB -25 B (-1%)
build/edit-navigation/style.css 3.1 kB -24 B (-1%)
build/edit-post/classic-rtl.css 479 B -4 B (-1%)
build/edit-post/classic.css 481 B -2 B (0%)
build/edit-post/index.min.js 59.4 kB -11 B (0%)
build/edit-post/style-rtl.css 7.19 kB -65 B (-1%)
build/edit-post/style.css 7.18 kB -61 B (-1%)
build/edit-site/index.min.js 26 kB -1 B (0%)
build/edit-site/style-rtl.css 5.01 kB -30 B (-1%)
build/edit-site/style.css 5.01 kB -24 B (0%)
build/edit-widgets/index.min.js 16.6 kB +418 B (+3%)
build/edit-widgets/style-rtl.css 4.01 kB +23 B (+1%)
build/edit-widgets/style.css 4.02 kB +30 B (+1%)
build/editor/index.min.js 38.3 kB -205 B (-1%)
build/editor/style-rtl.css 3.92 kB -35 B (-1%)
build/editor/style.css 3.91 kB -45 B (-1%)
build/format-library/index.min.js 5.72 kB -1 B (0%)
build/list-reusable-blocks/style-rtl.css 838 B -4 B (0%)
build/list-reusable-blocks/style.css 838 B -4 B (0%)
build/nux/index.min.js 2.31 kB -2 B (0%)
build/nux/style-rtl.css 747 B +2 B (0%)
build/nux/style.css 743 B +1 B (0%)
build/server-side-render/index.min.js 1.64 kB +1 B (0%)
build/widgets/index.min.js 6.48 kB -1 B (0%)
build/widgets/style-rtl.css 1.04 kB -4 B (0%)
build/widgets/style.css 1.04 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 1.12 kB
build/admin-manifest/index.min.js 1.46 kB
build/annotations/index.min.js 2.93 kB
build/autop/index.min.js 2.28 kB
build/blob/index.min.js 673 B
build/block-directory/index.min.js 6.62 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor.css 474 B
build/block-library/blocks/buttons/editor-rtl.css 315 B
build/block-library/blocks/buttons/editor.css 315 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/cover/editor.css 670 B
build/block-library/blocks/embed/style.css 400 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 711 B
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 93 B
build/block-library/blocks/group/theme.css 93 B
build/block-library/blocks/heading/editor-rtl.css 152 B
build/block-library/blocks/heading/editor.css 152 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/list/style-rtl.css 63 B
build/block-library/blocks/list/style.css 63 B
build/block-library/blocks/navigation-link/editor-rtl.css 474 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation/view.min.js 2.84 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 310 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style.css 248 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B
build/block-library/blocks/post-comments-form/style.css 140 B
build/block-library/blocks/post-comments/style-rtl.css 360 B
build/block-library/blocks/post-comments/style.css 359 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B
build/block-library/blocks/query-pagination/editor.css 262 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B
build/block-library/blocks/query-pagination/style.css 168 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 169 B
build/block-library/blocks/quote/style.css 169 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/social-link/editor.css 165 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/editor-rtl.css 90 B
build/block-library/blocks/term-description/editor.css 90 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/reset-rtl.css 514 B
build/block-serialization-default-parser/index.min.js 1.3 kB
build/block-serialization-spec-parser/index.min.js 3.06 kB
build/compose/index.min.js 10.2 kB
build/data-controls/index.min.js 831 B
build/date/index.min.js 31.8 kB
build/deprecated/index.min.js 738 B
build/dom-ready/index.min.js 576 B
build/dom/index.min.js 4.78 kB
build/element/index.min.js 3.44 kB
build/escape-html/index.min.js 739 B
build/format-library/style-rtl.css 668 B
build/format-library/style.css 669 B
build/hooks/index.min.js 1.76 kB
build/html-entities/index.min.js 628 B
build/i18n/index.min.js 3.73 kB
build/is-shallow-equal/index.min.js 710 B
build/keyboard-shortcuts/index.min.js 1.74 kB
build/keycodes/index.min.js 1.49 kB
build/list-reusable-blocks/index.min.js 2.07 kB
build/media-utils/index.min.js 3.08 kB
build/notices/index.min.js 1.07 kB
build/plugins/index.min.js 1.99 kB
build/primitives/index.min.js 1.06 kB
build/priority-queue/index.min.js 791 B
build/react-i18n/index.min.js 924 B
build/redux-routine/index.min.js 2.82 kB
build/reusable-blocks/index.min.js 2.56 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/rich-text/index.min.js 10.8 kB
build/shortcode/index.min.js 1.68 kB
build/token-list/index.min.js 848 B
build/url/index.min.js 1.95 kB
build/viewport/index.min.js 1.28 kB
build/warning/index.min.js 1.16 kB
build/wordcount/index.min.js 1.24 kB

compressed-size-action

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. I actually had a PR that was strikingly similar (#32574) which I closed as I thought the issue had been fixed by #33088. But apparently that was incorrect.

So in my own past testing, and testing now, this seems to work well:

after

I left a comment about providing some default margin instead of removing it entirely. But otherwise, let's land this.

@jasmussen
Copy link
Contributor

On a separate note, 2020 is not the best theme to test with, as it hasn't been kept up to date with changes to editor styles. See also #18571.

A great theme to test with is "Empty Theme" from https://github.com/WordPress/theme-experiments, then you'll know that you won't be fixing errors in editor styles, but actual errors in the block editor.

@mkaz mkaz merged commit 333668e into trunk Aug 2, 2021
@mkaz mkaz deleted the fix/33487-justify branch August 2, 2021 16:46
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Aug 2, 2021
@mkaz mkaz modified the milestones: Gutenberg 11.3, WordPress 5.8.1 Aug 2, 2021
@mkaz mkaz added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Aug 2, 2021
@jasmussen jasmussen mentioned this pull request Aug 4, 2021
7 tasks
desrosj pushed a commit that referenced this pull request Aug 30, 2021
* Remove margin setting, auto right conflict with justify buttons

* Per review, add little margin back
@desrosj desrosj mentioned this pull request Aug 30, 2021
7 tasks
desrosj added a commit that referenced this pull request Sep 1, 2021
* Fix API docs generation (#33384)

* Docs: use markdown headings instead of links for API declarations (#33381)

* Docs: Run Prettier after updating API in documentation (#33498)

(cherry picked from commit 626f233)

* Use tabs instead of spaces in block transform doc example (#33549)

(cherry picked from commit 8afca1e)

* Fix metabox reordering (#30617).

* Block editor: don't render layout and duotone styles in between blocks (#32083)

* Widgets: Allow HTML tags in description (#33814)

* Widgets: Allow HTML tags in description

* Use `dangerouslySetInnerHTML`

Avoid `<div />` inside the `<p />` tag

* Describe by dangerouslySetInnerHTML is used

* Use safeHTML

* Update comment

* Editor: Set 'hide_empty' for the most used terms query (#33457)

Don't include terms that aren't assigned to any posts as "most used" terms.

* Update widget editor help links to point to the new support article (#33482)

* If select-all fires in .editor-post-title__input, end the process.. (#33621)

* Writing flow: select all: remove early return for post title (#33699)

* Call onChangeSectionExpanded conditionally (#33618)

* FontSizePicker: Use number values when the initial value is a number (#33679)

* FontSizePicker: Don't use units if the value is a number
* Add unit tests
* Disable units when we have number values

* Fix justification for button block when selected (#33739)

* Remove margin setting, auto right conflict with justify buttons

* Per review, add little margin back

* Add error boundaries to widget screens (#33771)

* Add error boundary to edit widgets screen

* Add error boundary to customize widgets

* Refactor sidebar controls provider to application level so that its state is not lost when re-initializing

* Revert "Refactor sidebar controls provider to application level so that its state is not lost when re-initializing"

This reverts commit 7d607ff.

* Remove rebootability from customize widgets

* Remove debug code

* Fix insertion point in Widgets editors (#33802)

* Default batch processor: Respect the batch endpoint's maxItems (#34280)

This updates the default batch processor to make multiple batch requests
if the number of requests to process exceeds the number of requests that
the batch endpoint can handle.

We determine the number of requests that the batch endpoint can handle
by making a preflight OPTIONS request to /batch/v1. By default it is 25
requests.

See https://make.wordpress.org/core/2020/11/20/rest-api-batch-framework-in-wordpress-5-6/.

* Fix button block focus trap after a URL has been added (#34314)

* Rework button block link UI to match RichText format implementation

* Refine some more, determine visibility by selection and url state

* Add e2e test

* Also focus rich text when unlinking using a keyboard shortcut

* Text for dropdown fields within legacy widgets in the Customizer is off centered (#34076)

* Fix ESLint errors reported

* Regenerate autogenerated docs

* Update the `INSERTER_SEARCH_SELECTOR` path.

This is a partial cherry pick of 2356b2d in order to fix the performance tests.

Co-authored-by: André <nosolosw@users.noreply.github.com>
Co-authored-by: JuanMa <juanma.garrido@gmail.com>
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Co-authored-by: Jeff Bowen <jblz@users.noreply.github.com>
Co-authored-by: Bruno Ribarić <43731400+ribaricplusplus@users.noreply.github.com>
Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Petter Walbø Johnsgård <petter@dekode.no>
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
Co-authored-by: Hiroshi Urabe <mail@torounit.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Co-authored-by: Robert Anderson <robert@noisysocks.com>
Co-authored-by: Anton Vlasenko <43744263+anton-vlasenko@users.noreply.github.com>
@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons block: justification setting ignored when the block is selected
3 participants