Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link control rich preview - improve image placeholder #32548

Closed
Tracked by #35073
getdave opened this issue Jun 9, 2021 · 6 comments
Closed
Tracked by #35073

Link control rich preview - improve image placeholder #32548

getdave opened this issue Jun 9, 2021 · 6 comments
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@getdave
Copy link
Contributor

getdave commented Jun 9, 2021

What problem does this address?

In #31464 @javierarce mentioned the following...

Currently, if an image in the <LinkContorl> rich preview isn't available we show a placeholder. However, it may not be clear that this is a placeholder.

What is your proposed solution?

To improve this we can add the URL to the placeholder as shown in this mockup

Screenshot 2021-06-09 at 13 04 35

https://www.figma.com/file/OXOmvYcX0Gpwgt7FB5LlKA/Rich-URL-metadata?node-id=152%3A0

@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Jun 9, 2021
@getdave getdave self-assigned this Jun 9, 2021
@mtias
Copy link
Member

mtias commented Jul 30, 2021

@getdave @javierarce I'm also noticing that rendering a big placeholder for image and text is a bit annoying when the result cannot retrieve a preview, which seems to happen often. It seems it'd be better to only have a placeholder on the icon and then expand if there is image and description, instead of collapsing when there isn't, which seem odd.

@javierarce
Copy link
Contributor

That was the initial idea, but there was an issue (described here) where the popup moved suddenly when new content appeared.

@mtias
Copy link
Member

mtias commented Jul 30, 2021

Ah, I see! Now we have the jump in the other direction in some cases. We should look at addressing it in the popover. I don't when it'd be not disorienting to have a rendered popover reposition itself when its content updates if there's no resize / scroll.

@getdave
Copy link
Contributor Author

getdave commented Jul 30, 2021

I seem to recall that Popover is due a major refactor or replacement in the near future. Was there someone working on that? I can't quite recall. Perhaps @javierarce or @jasmussen would know?

@mtias
Copy link
Member

mtias commented Jul 30, 2021

@diegohaz was looking into it

@getdave
Copy link
Contributor Author

getdave commented Sep 23, 2021

The placeholder now no longer appears if there is no image retrieved. See #32547.

Closing.

@getdave getdave closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Development

No branches or pull requests

3 participants