Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: LinkControl tracking issue #35073

Open
23 of 39 tasks
fabiankaegy opened this issue Sep 23, 2021 · 9 comments
Open
23 of 39 tasks

Component: LinkControl tracking issue #35073

fabiankaegy opened this issue Sep 23, 2021 · 9 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@fabiankaegy
Copy link
Member

fabiankaegy commented Sep 23, 2021

The LinkControl Component was added via #17557 as an experimental component in September 2019.

This Tracking issue is here to keep track of the items that are needed to get the Component out of the experimental state.

See also the Link UI Overview Issue which tracks currently priorities.

High Priority

Medium Priority

TBD

Low Priority

TBD


Issues to organize

Enhancements

Bugs

Accessibility

@fabiankaegy fabiankaegy added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Components /packages/components labels Sep 23, 2021
@getdave
Copy link
Contributor

getdave commented Sep 23, 2021

Great work on this. We should add a dedicated Accessibility section so as to ensure these are given a high priority.

@jasmussen
Copy link
Contributor

Fresh mockups here: #26351 (comment)

@fabiankaegy
Copy link
Member Author

Question:

What's holding us from stabilizing this component?

It was introduced into the codebase in September 2019 #17557 and whilst it is currently undergoing another design revision that from my perspective has very little to nothing to do with the actual API of the component. Which has changed very little in all these years.

I feel strongly that this is a core component that is being used widely throughout the Gutenberg codebase and because it was introduced before the new private API system is also widely used outside of core.

I would love for us to recognize that fact and stabilize the LinkControl component sooner rather than later.

We can always tweak the underlying tech / the visuals of the component further as we are doing with other stable components.

CC: @getdave

@getdave
Copy link
Contributor

getdave commented Jul 12, 2023

@fabiankaegy Your arguments are sound.

Because the work to update the UX of the component is still ongoing from 6.2 -> 6.3 (and on into 6.4 where we hope to wrap up) it didn't seem like a great time to stablise the component.

I think @richtabor (who's been working with me on this) would agree that we should be able to wrap up the updates to the component in the 6.4 cycle and thus we could look to stablise for that release.

This depends on contributors and where we need to allocate time however, so it might be better thinking of it as "a near future release" as opposed to committing to an specific release.

@richtabor
Copy link
Member

I think @richtabor (who's been working with me on this) would agree that we should be able to wrap up the updates to the component in the 6.4 cycle and thus we could look to stablise for that release.

Yes, it really should be ironed out and used throughout the experience for 6.4.

@fabiankaegy
Copy link
Member Author

@getdave @richtabor coming back to this, do we now feel like we can finally stabilize this component?

Looking at the usage stats there are over 200 plugins in the official Repo already using the component, many of which have a really large user base.

Regardless of us continuing to evolve the actual UI of the component I think it is way past time for us to stabilize the API of the component.

@getdave
Copy link
Contributor

getdave commented Dec 14, 2023

Just tying up loose ends and making sure that the Design / UX refresh for this component is linked here.

@fabiankaegy
Copy link
Member Author

@getdave like I said before, I do not think that stabilizing this component has much to do with us still iterating on the UX & design of the component.

The API itself has remained stable for over 3 years now and is getting used in hundreds of plugins in the repository.

Therefore I think it is time to stabilize the component now.

The work to improve the UI can be an ongoing effort like it is for other components we have.

@getdave
Copy link
Contributor

getdave commented Dec 14, 2023

@fabiankaegy my comment is purely for update purposes because I realised the Design refresh was not linked here anywhere. Your previous comments still stand. Let's look at landing your stablising PR in 6.5.

@mirka mirka added [Package] Block editor /packages/block-editor and removed [Package] Components /packages/components labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

5 participants