Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl UI goes off screen #42003

Closed
javierarce opened this issue Jun 28, 2022 · 3 comments · Fixed by #42389
Closed

LinkControl UI goes off screen #42003

javierarce opened this issue Jun 28, 2022 · 3 comments · Fixed by #42389
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended

Comments

@javierarce
Copy link
Contributor

Description

Because the LinkControl popover appears horizontally centered relative to the link it modifies, in some cases (like editing the first item of a Navigation block), the interface appears out of the screen, making it very difficult to use.

In cases like this, the LinkControl popover should appear left-centered under the link (or right-aligned, in case the user is editing a link that is next to the right border of the screen)

Step-by-step reproduction instructions

  1. Add a blank navigation menu on top of a template
  2. Add a link
  3. Without having the List view open, click on the link

Screenshots, screen recording, code snippet

LinkControl.navigation.block.mov

Environment info

  • WordPress 6.0, Gutenberg 13.5.1
  • Tested in Chrome, Firefox, and Safari for mac

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@javierarce javierarce added [Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jun 28, 2022
@javierarce
Copy link
Contributor Author

javierarce commented Jun 28, 2022

@javierarce javierarce added the [Type] Bug An existing feature does not function as intended label Jun 28, 2022
@talldan
Copy link
Contributor

talldan commented Jul 1, 2022

The same thing seems to have been encountered in the widget editor - #41739.

@carolinan
Copy link
Contributor

carolinan commented Jul 8, 2022

Can also reproduce this with other blocks than the navigation block.

@talldan talldan self-assigned this Jul 13, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 13, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants