Block editor: "Select all" keyboard shortcut doesn't work anymore in WP 5.8

[audrasjb]

Description

It looks like there is a regression in the block editor. The cmd + A / ctrl + A keyboard shortcut doesn't work anymore.

• In 5.7.2 and before, one could use this shortcut to select all the blocks available in the current post.
• In 5.8 RC 2, using this shortcut results in selecting the whole HTML content of the editor screen (see screenshot below).

Screenshots or screen recording (optional)

WordPress information

• WordPress version: 5.8 RC 2
• Gutenberg version: Not installed
• Are all plugins except Gutenberg deactivated? Yes
• Are you using a default theme (e.g. Twenty Twenty-One)? Yes (Twenty Twenty)

Device information

• Device: Desktop
• Operating system: OSX
• Browser: Chrome last version

[gziolo]

I see that a related fix #33167 from @adamziel might have been already cherry-picked to WP 5.8 recently. Although, it addresses a different issue.

[audrasjb]

I see that a related fix #33167 from @adamziel might have been already cherry-picked to WP 5.8 recently. Although, it addresses a different issue.

Cool. Indeed it addresses a different issue but hopefully it may fix the problem?
That said, it wasn't backported for now

[gziolo]

I can confirm that this is a regression.

I found this code in WP 5.7 and it's missing in 5.8:

useShortcut(
		'core/block-editor/select-all',
		useCallback(
			( event ) => {
				event.preventDefault();
				multiSelect(
					first( rootBlocksClientIds ),
					last( rootBlocksClientIds )
				);
			},
			[ rootBlocksClientIds, multiSelect ]
		)
	);

It was moved to a different file (packages/block-editor/src/components/writing-flow/use-select-all.js) in 5d0b0f6.

It was further refactored in 37c5148 to stop using useShortcut call, but I see that 'core/block-editor/select-all' shortcut is still being registered in this place:

gutenberg/packages/block-editor/src/components/keyboard-shortcuts/index.js

Lines 218 to 228 in 64f1de6

	registerShortcut( {
	name: 'core/block-editor/select-all',
	category: 'selection',
	description: __(
	'Select all text when typing. Press again to select all blocks.'
	),
	keyCombination: {
	modifier: 'primary',
	character: 'a',
	},
	} );

@ellatrix, any hints on how to resolve this issue?

[ellatrix]

It looks like the content is not focused nor is nothing selected when you press cmd+a?

[Mamaduka]

It looks like the content is not focused nor is nothing selected when you press cmd+a?

Yes, this happens when content isn't focused or selected. However, if I focus on content, then the shortcut works as expected.

[gziolo]

#33446 should fix it.

[audrasjb]

Thanks all for working on this issue <3

[audrasjb]

Hi, while testing WP 5.8 RC4 package, I noticed it didn't fix the issue.
I think it's worth to reopen this issue to make it sure it can be addressed before 5.8 is released, if it's even possible :)

[audrasjb]

Ok so if you first put the focus on the editor area then it works fine. I think it’s not as good as the previous behavior, but it’s not a blocker anymore for 5.8 in my opinion.