Fix "Select all" behavior in the editor #33167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Writing Flow
adamziel
requested review from
youknowriad,
draganescu,
ellatrix,
getdave and
gziolo
|
Size Change: +43 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
getdave
reviewed
Jul 2, 2021
draganescu
added
the
Needs Technical Feedback
|
This is good @adamziel. In the post editor things a lot better with this. testing this. However, I realized that pressing Cmd + A a third time selects all widget areas. |
noisysocks
added
the
Backport to WP 6.7 Beta/RC
This isn't a problem with cmd+a per se. Selecting all the widget areas using your mouse is a possible and valid behavior at the moment. I agree it doesn't a lot of sense for the user to do that, so maybe we should disallow it somehow @draganescu. Either way, this would be a new issue. |
…se the selection does not belong to the top-level children directly
ellatrix
reviewed
Jul 5, 2021
packages/e2e-tests/specs/editor/various/multi-block-selection.test.js
Outdated
Show resolved
Hide resolved
ellatrix
reviewed
Jul 5, 2021
packages/e2e-tests/specs/editor/various/multi-block-selection.test.js
Outdated
Show resolved
Hide resolved
ellatrix
reviewed
Jul 5, 2021
packages/e2e-tests/specs/editor/various/multi-block-selection.test.js
Outdated
Show resolved
Hide resolved
noisysocks
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Make isEntirelySelected consider "deep" first and last children in case the selection does not belong to the top-level children directly * Rollback unit tests – jsdom does not support contentEditable jsdom/jsdom#1670 * Add an e2e test for multi-block selection * Adjust e2e tests * Add a separate test for gradual select-all from within the list block * Cosmetic adjustments to the e2e test * Update the snapshot
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Make isEntirelySelected consider "deep" first and last children in case the selection does not belong to the top-level children directly * Rollback unit tests – jsdom does not support contentEditable jsdom/jsdom#1670 * Add an e2e test for multi-block selection * Adjust e2e tests * Add a separate test for gradual select-all from within the list block * Cosmetic adjustments to the e2e test * Update the snapshot
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Make isEntirelySelected consider "deep" first and last children in case the selection does not belong to the top-level children directly * Rollback unit tests – jsdom does not support contentEditable jsdom/jsdom#1670 * Add an e2e test for multi-block selection * Adjust e2e tests * Add a separate test for gradual select-all from within the list block * Cosmetic adjustments to the e2e test * Update the snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When my cursor in in a block like "list" and I press cmd+a twice, the selection doesn't expand to all blocks anymore:
The issue is caused by
isEntirelySelectedonly checking the selection container against block'sfirstChild– which in this case isli. The actual selection is pinned to the text note inside of thatli. This PR explores resolving that using a deep comparison instead of a shallow comparison.The issue is reproducible across all editors (posts, pages, widgets etc.)
How has this been tested?
By interacting with the editor, unfortunately. I wanted to cover this with unit tests, but jsdom doesn't support contentEditable very well: jsdom/jsdom#1670
This means that the only way to test it is by adding some E2E tests. That's fine with me, but since that's cumbersome I'd rather get some comments on the approach first.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).