Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: disallow importing Enzyme for React testing #34437

Closed
2 tasks
ciampo opened this issue Sep 1, 2021 · 1 comment
Closed
2 tasks

ESLint: disallow importing Enzyme for React testing #34437

ciampo opened this issue Sep 1, 2021 · 1 comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality

Comments

@ciampo
Copy link
Contributor

ciampo commented Sep 1, 2021

Why

We should recommend using RTL instead of Enzyme for all new tests

What

We should add a ESLint rule to help enforce that

A/C

  • Add new ESLint rule
  • Disable rule in all existing files importing Enzyme

Originally posted by @gziolo in #34423 (comment)
@ciampo ciampo added [Type] Code Quality Issues or PRs that relate to code quality [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Sep 1, 2021
@ciampo ciampo mentioned this issue Sep 1, 2021
Merged
2 tasks
@tyxla
Copy link
Member

tyxla commented Dec 12, 2022

We can actually close this, enzyme has been gone for almost 3 months since we removed it in #44494.

@tyxla tyxla closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ciampo @tyxla