Testing: Remove enzyme completely #44494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Developer Documentation
tyxla
requested review from
Mamaduka,
youknowriad,
getdave,
ciampo and
ntsekouras
tyxla
requested review from
ntwb,
nerrad,
ajitbohra,
ellatrix,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
This was referenced Sep 27, 2022
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
gziolo
reviewed
Sep 27, 2022
There was a problem hiding this comment.
Excellent work on replacing Enzyme with React Testing Library.
All code changes look great. We should ensure that we have documented the case when some project use enzyme so they know what to install and configure so they can continue using their current tests.
There is one open question for future work. Should we make RTL a part of the default Jest preset we ship with @wordpress/scripts?
|
Fantastic work, @tyxla! |
tyxla
force-pushed
the
remove/enzyme
branch
from
8e5c8c2
to
f6d12ec
Compare
We could, potentially. What benefit would that yield, though on top of always including |
|
I've rebased after merging the dependency PRs, and I think all feedback has been addressed and the PR is ready for another look 👀 . |
|
It seems like we were implicitly relying on |
tyxla
force-pushed
the
remove/enzyme
branch
from
11abc19
to
e36a112
Compare
tyxla
removed
the
[Status] Blocked
|
Nice :) |
Closed
|
Here's a draft dev note, feel free to edit at will, everyone: Dropping Enzyme in favor of
|
tyxla
added
has dev note
|
fwiw enzyme absolutely will be compatible with react 18 at some point. |
Good to know, thanks @ljharb! I've edited the dev note to account for this. |
|
I’ll also point out that the effort y’all expended on this transition could have probably helped me get enzyme compatible with react 17/18 twice over :-/ |
It's worth mentioning that this hasn't been an intentional crusade against Enzyme. Historically, Enzyme has been an indispensable utility in our testing toolchain, and we've been infinitely thankful to have it. Given that we had decided to go ahead with using However, recently, we've found a lot of value in using Eventually, we could have a use for On a personal note, I'm curious if any progress has been made on the migration to offer first-class support for React 17 and 18. What kind of help would you be looking for to get it to the finish line? |
|
Understood. I'm not aware of much that RTL has that enzyme's I just wanted to make it clear for future readers that enzyme's lack of movement is almost exclusively due to about 3-4 years worth of time where virtually no money, and only a few humans' time, have been offered. To get React 17 support over the finish line (which is an obvious prereq for 18 support), I'd need nonzero people to devote the time to ramp up on the project and its testing conventions, and pair with me on getting the 17 adapter passing tests and released - after which we could build the 18 adapter off of that, and evaluate how much work that would take. To avoid further noise for gutenberg, if anyone's interested in discussing further, please file an issue on enzyme, or reach out to me on any of the numerous mediums I have an account, and we can chat! |
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR gets rid of good old
enzymenow that we've migrated all tests to use@testing-library/react.Fixes #17249.
Why?
Enzyme has been a major blocker for upgrading to React 18, so it's great to see it gone!
How?
We're getting rid of the enzyme dependency, its React 17 adapter and snapshot serializers.
This PR includes #44492 and #44493 and should be rebased after they land.We're also consequently getting rid of the last usage of
underscore, as explained here.Testing Instructions
Verify all checks are green.
Notes
This change definitely deserves a dev note.