Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "group" and variations (Row, Stack) in multi-select toolbar #34461

Closed
1 of 2 tasks
mtias opened this issue Sep 1, 2021 · 7 comments
Closed
1 of 2 tasks

Show "group" and variations (Row, Stack) in multi-select toolbar #34461

mtias opened this issue Sep 1, 2021 · 7 comments
Assignees
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Sep 1, 2021

Let's surface the "group" action on the multi-select toolbar:

image

It's a more common action to do when you multi-select and it's unnecessary buried:

image

To-do

@mtias mtias added [Feature] Block Multi Selection The ability to select and manipulate multiple blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Sep 1, 2021
@kjbenk
Copy link

kjbenk commented Nov 22, 2021

@mtias Any thoughts about whether the other MenuItem of Add to Reusable Blocks should be moved as well? Does it make sense to move the Group MenuItem from that MenuGroup and add it to the top of the list? This would mean that Add to Reusable Blocks would be the only MenuItem in that group.

@kjbenk
Copy link

kjbenk commented Nov 22, 2021

@mtias After looking into this some more, it seems like the Group menu item is added to the general BlockSettingsMenuControls slot (which developers can extend and add other items as desired). Would it be useful to move this button out of this menu group and into the main group (i.e. where Copy and Paste are)?

Also, it might be ideal if the Group button remained in the same relative location regardless of if multiple blocks were selected. I can see users getting confused if the Group item were to change location in the dropdown based on whether multiple blocks were selected.

@jiteshdhamaniya
Copy link
Contributor

jiteshdhamaniya commented Dec 17, 2021

Created a PR #37488 for this.

@jiteshdhamaniya
Copy link
Contributor

Created a PR #37488 for this.

I think I misunderstood and just moved up Group Menu in my PR.

@mtias in order to add it to multi-select toolbar, we need an icon, is there any existing icon we can use?

@mtias
Copy link
Member Author

mtias commented Dec 20, 2021

@jiteshdhamaniya Yes, the group icon can be used:

image

@jiteshdhamaniya
Copy link
Contributor

jiteshdhamaniya commented Dec 20, 2021

@jiteshdhamaniya Yes, the group icon can be used:

image

alright, thanks. I will create a new PR.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 24, 2022
@andrewserong andrewserong changed the title Show "group" in multi-select toolbar Show "group" and variations (Row, Stack) in multi-select toolbar Mar 25, 2022
@andrewserong andrewserong removed the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Mar 25, 2022
@andrewserong
Copy link
Contributor

Just closing this one out now as it was resolved by #34461 and #39920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

No branches or pull requests

4 participants