Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformed or split Heading blocks have incorrect line height for block themes #38421

Closed
dcalhoun opened this issue Feb 1, 2022 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Feb 1, 2022

Description

Related to #37168. While a block theme is utilized, transforming a block to a Heading block or splitting an existing Heading block results in the Heading block displaying an incorrect line height. This results in longer, wrapping text overlapping itself.

The solution in #37285 addressed the issue for typing into a Heading block, but transforming/splitting appears to remain an issue.

This issue occurs only on Android, it does not occur on iOS.

Step-by-step reproduction instructions

  1. Add a Paragraph block.
  2. Type enough text so that the text will wrap.
  3. Transform the Paragraph block to a Heading block.

Expected behaviour

The correct line height is applied to the Heading block and the text is not overlapping.

Actual behaviour

The incorrect line height is applied to the Heading block and the text is overlapping.

Screenshots or screen recording (optional)

Screen_Recording_20220201-112816.mp4

WordPress information

  • WordPress version: WordPress.com
  • Gutenberg version: 12.4.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No, Geologist.

Device information

  • Device: Samsung Galaxy S20
  • Operating system: Android 11
  • WordPress app version: 18.9
@dcalhoun dcalhoun added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 1, 2022
@hypest hypest added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Feb 2, 2022
@geriux
Copy link
Member

geriux commented Feb 3, 2022

This should be fixed in #38205 to be confirmed in the 1.71.0 release.

@geriux
Copy link
Member

geriux commented Feb 4, 2022

I've just confirmed in the 1.71.0 build that this issue is fixed 🎉

Screenrecorder-2022-02-04-10-47-26-597.mp4

Closing the issue 😃

@geriux geriux closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants