Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.70.1 #4518

Merged
merged 9 commits into from
Feb 2, 2022
Merged

Release 1.70.1 #4518

merged 9 commits into from
Feb 2, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 27, 2022 •
edited
Loading

Release for Gutenberg Mobile 1.70.1

Related PRs

Extra PRs that Landed After the Release Was Cut

Video preview not launching on Android 11

Changes

Gallery block: Fix crash when adding images and selecting a gallery item

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jan 27, 2022
Merged
Merged
Merged
@fluiddot fluiddot mentioned this pull request Jan 27, 2022
Merged
4 tasks
@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 27, 2022 •
edited
Loading

🟢 iOS - Test new changes included in 1.70.1 release

Build: 65052
Device: iPhone 11 (iOS 15.1)

@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 27, 2022 •
edited
Loading

🟢 iOS - Writing Flow checklist

Build: 65052
Device: iPhone 11 (iOS 15.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot fluiddot marked this pull request as ready for review January 27, 2022 13:19
@fluiddot fluiddot requested a review from geriux January 27, 2022 13:20
@geriux
Copy link
Member

geriux commented Jan 27, 2022 •
edited
Loading

🟢 Android New changes

Build: 118592
Device: Redmi Note 8T (OS 11)

@geriux
Copy link
Member

geriux commented Jan 27, 2022 •
edited
Loading

⚪️ Android - Writing Flow checklist

Build: 118592
Device: Redmi Note 8T (OS 11)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Feb 1, 2022 •
edited
Loading

🟢 Android - Writing Flow checklist

Build: 118592
Device: Samsung Galaxy S20 (Android 11)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

dcalhoun
dcalhoun approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM. Before merging, we'll need to update the Gutenberg reference to the tag created for the release.

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
@dcalhoun dcalhoun merged commit 5ad0b36 into trunk Feb 2, 2022
@dcalhoun dcalhoun deleted the release/1.70.1 branch February 2, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

@geriux geriux Awaiting requested review from geriux

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fluiddot @geriux @dcalhoun