Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] uploaded images' captions can be edited #39533

Closed
github-actions bot opened this issue Mar 17, 2022 · 9 comments · Fixed by #39565 or #39689
Closed

[Flaky Test] uploaded images' captions can be edited #39533

github-actions bot opened this issue Mar 17, 2022 · 9 comments · Fixed by #39565 or #39689
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Mar 17, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

uploaded images' captions can be edited

Test path

/test/e2e/specs/editor/blocks/gallery.spec.js

Errors

[2022-03-17T07:26:58.411Z] Test passed after 1 failed attempt on fix/flex-layout-allow-orientation-flag.
[2022-03-23T23:25:52.098Z] Test passed after 1 failed attempt on fix/comment-query-loop-do-not-inherit-settings.
[2022-03-24T00:29:15.273Z] Test passed after 1 failed attempt on types/expand-data-registry.
[2022-03-24T00:45:01.126Z] Test passed after 1 failed attempt on fix/fallback-on-default-layout.
[2022-03-24T01:21:32.257Z] Test passed after 1 failed attempt on trunk.
[2022-03-24T02:33:25.911Z] Test passed after 2 failed attempts on add/border-box-control.
[2022-03-24T03:06:11.276Z] Test passed after 2 failed attempts on trunk.
[2022-03-25T17:12:06.888Z] Test passed after 1 failed attempt on rnmobile/feature/drag-and-drop-use-scroll-when-dragging.
[2022-03-28T11:16:06.505Z] Test passed after 1 failed attempt on rnmobile/feature/drag-and-drop-block-draggable-component.
[2022-03-30T10:08:13.563Z] Test passed after 1 failed attempt on rnmobile/feature/drag-and-drop-use-scroll-when-dragging.
[2022-04-04T17:30:51.034Z] Test passed after 1 failed attempt on rnmobile/feature/drag-and-drop-use-on-block-drop.
[2022-10-14T16:40:38.529Z] Test passed after 2 failed attempts on add/image-caption-toolbar-item.
[2022-10-19T08:43:25.677Z] Test passed after 1 failed attempt on refactor/add-save-props-omit.
[2022-10-19T08:55:25.062Z] Test passed after 2 failed attempts on fix/eslint-testing-library/prefer-screen-queries.
[2022-10-19T09:08:29.996Z] Test passed after 1 failed attempt on refactor/lodash-castarray.
[2022-10-19T10:49:37.362Z] Test passed after 2 failed attempts on update/comment-template-spacing.
[2022-10-19T11:43:22.908Z] Test passed after 1 failed attempt on refactor/with-global-events-tests-rtl.
[2022-10-19T11:44:11.720Z] Test passed after 1 failed attempt on update/file-spacing-support.
[2022-10-19T11:58:52.236Z] Test passed after 1 failed attempt on trunk.
[2022-10-19T12:12:30.947Z] Test passed after 1 failed attempt on fix/tumblr-embed-url.
[2022-10-19T12:31:24.879Z] Test passed after 2 failed attempts on update/latest-spacing-support.
[2022-10-19T12:39:58.623Z] Test passed after 2 failed attempts on trunk.
[2022-10-19T13:12:53.686Z] Test passed after 2 failed attempts on add/eslint-plugin-testing-library.
[2022-10-19T13:42:21.753Z] Test passed after 1 failed attempt on trunk.
[2022-10-19T13:49:21.400Z] Test passed after 1 failed attempt on add-anchor-support.
[2022-10-19T14:15:14.618Z] Test passed after 2 failed attempts on add/caption-toolbar-button-video-block.
[2022-10-19T14:58:53.590Z] Test passed after 1 failed attempt on fix/toggle-group-types.
[2022-10-19T16:15:28.481Z] Test passed after 1 failed attempt on trunk.
[2022-10-19T17:03:01.952Z] Test passed after 2 failed attempts on release/14.4.
[2022-10-19T17:08:25.265Z] Test passed after 1 failed attempt on try/block-mover-button-focus-styles.
[2022-10-19T17:13:39.758Z] Test passed after 1 failed attempt on add/image-block-caption-class.
[2022-10-19T17:19:50.361Z] Test passed after 1 failed attempt on wp/latest.
[2022-10-19T17:31:39.499Z] Test passed after 1 failed attempt on trunk.
[2022-10-19T18:48:44.334Z] Test passed after 1 failed attempt on add/caption-toolbar-button-audio-block.
[2022-10-19T19:40:21.280Z] Test passed after 2 failed attempts on toggle-group-multiple.
[2022-10-19T20:44:31.759Z] Test passed after 2 failed attempts on refactor/Snackbar-exhaustive-deps.
[2022-10-19T21:05:05.353Z] Test passed after 2 failed attempts on add/image-block-caption-class.
[2022-10-19T23:52:00.183Z] Test passed after 1 failed attempt on trunk.
[2022-10-20T00:12:25.234Z] Test passed after 2 failed attempts on add/block-post-time-to-read.
[2022-10-20T00:20:31.214Z] Test passed after 2 failed attempts on add/image-block-caption-class.
[2022-10-20T00:40:41.765Z] Test passed after 1 failed attempt on add/hide-toolbar-when-visualizer-showing.
[2022-10-20T01:23:32.278Z] Test passed after 1 failed attempt on add/image-block-caption-class.
[2022-10-20T02:09:49.850Z] Test passed after 1 failed attempt on add/image-block-caption-class.
[2022-10-20T06:30:39.387Z] Test passed after 1 failed attempt on cleanup/data-object-fit.
[2022-10-20T07:15:37.015Z] Test passed after 1 failed attempt on add/frameless-popover-variation.
[2022-10-20T08:33:53.879Z] Test passed after 1 failed attempt on refactor/Context-exhaustive-deps.
[2022-10-20T09:39:54.640Z] Test passed after 1 failed attempt on trunk.
[2022-10-20T09:40:42.831Z] Test passed after 1 failed attempt on fix/site-title-persmissions-error.
[2022-10-20T09:46:18.493Z] Test passed after 1 failed attempt on try/block-mover-button-focus-styles.
[2022-10-20T10:13:00.847Z] Test passed after 1 failed attempt on update/comment-count-spacing.
[2022-10-20T10:39:13.802Z] Test passed after 1 failed attempt on toggle-group-deselectable.
[2022-10-20T10:41:31.507Z] Test passed after 1 failed attempt on toggle-group-multiple.
[2022-10-20T11:20:40.829Z] Test passed after 1 failed attempt on add/navigation-playwright-tests.
[2022-10-20T11:31:30.362Z] Test passed after 1 failed attempt on trunk.
[2022-10-20T11:40:47.028Z] Test passed after 2 failed attempts on fix/43660-separator-background-style-variation.
[2022-10-20T12:13:20.172Z] Test passed after 1 failed attempt on trunk.
[2022-10-20T12:31:36.042Z] Test passed after 2 failed attempts on fix/components-angle-picker-storybook-label-control.
[2022-10-20T14:15:53.561Z] Test passed after 1 failed attempt on wp/latest.
[2022-10-20T14:18:52.346Z] Test passed after 1 failed attempt on trunk.
[2022-10-20T14:53:31.827Z] Test passed after 1 failed attempt on fix/table-deprecation.
[2022-10-20T14:53:35.495Z] Test passed after 1 failed attempt on trunk.
[2022-10-20T15:49:10.515Z] Test passed after 2 failed attempts on add/deprecations-for-embed-captions.
[2022-10-20T17:11:00.885Z] Test passed after 2 failed attempts on add/deprecation-for-gallery-block.
[2022-10-20T18:19:42.250Z] Test passed after 1 failed attempt on tests/record-cpus-data.
[2022-10-20T19:14:23.455Z] Test passed after 2 failed attempts on add/image-editor-batch-api.
[2022-10-20T22:06:16.524Z] Test passed after 1 failed attempt on add/deprecation-for-gallery-block.
[2022-10-20T23:01:42.993Z] Test passed after 1 failed attempt on tests/measure-perf-test-runtimes.
[2022-10-20T23:57:30.379Z] Test passed after 1 failed attempt on add/video-caption-deprecation.
[2022-10-21T00:13:54.020Z] Test passed after 1 failed attempt on add/storybook-wrapper-addon.
[2022-10-21T00:58:17.542Z] Test passed after 1 failed attempt on add/file-block-deprecation.
[2022-10-21T02:45:00.955Z] Test passed after 2 failed attempts on dependabot/github_actions/actions/download-artifact-3.0.1.
[2022-10-21T03:54:06.045Z] Test passed after 1 failed attempt on fix/distraction-free-shortcut-typo.
[2022-10-21T04:44:55.742Z] Test passed after 2 failed attempts on fix/table-deprecation.
[2022-10-21T05:15:43.984Z] Test passed after 2 failed attempts on trunk.
[2022-10-21T05:40:19.230Z] Test passed after 1 failed attempt on add/eslint-plugin-testing-library.
[2022-10-21T06:35:21.209Z] Test passed after 2 failed attempts on trunk.
[2022-10-21T06:43:04.871Z] Test passed after 1 failed attempt on fix/uploading-failure-artifacts.
[2022-10-21T07:09:28.573Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T07:18:46.134Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T07:43:18.447Z] Test passed after 1 failed attempt on update/playwright-1-27.
[2022-10-21T08:07:52.489Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T08:56:10.470Z] Test passed after 2 failed attempts on trunk.
[2022-10-21T09:01:36.805Z] Test passed after 1 failed attempt on update/preformatted-spacing.
[2022-10-21T09:35:11.912Z] Test passed after 1 failed attempt on add/button-is-busy-knobs.
[2022-10-21T10:41:15.792Z] Test passed after 1 failed attempt on fix/43660-separator-background-style-variation.
[2022-10-21T10:47:19.068Z] Test passed after 2 failed attempts on refactor/Context-exhaustive-deps.
[2022-10-21T11:44:27.838Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T12:12:52.847Z] Test passed after 2 failed attempts on add/playwright-compatibility.
[2022-10-21T13:39:18.241Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T13:59:02.245Z] Test passed after 1 failed attempt on revert-45192-refactor/edit-site-kebabcase.
[2022-10-21T14:41:34.287Z] Test passed after 2 failed attempts on refactor/border-box-control-tests.
[2022-10-21T15:03:27.085Z] Test passed after 2 failed attempts on fix/43660-separator-background-style-variation.
[2022-10-21T15:09:59.278Z] Test passed after 1 failed attempt on dependabot/npm_and_yarn/actions/core-1.9.1.
[2022-10-21T15:11:35.732Z] Test passed after 2 failed attempts on dependabot/github_actions/actions/setup-java-3.6.0.
[2022-10-21T15:13:49.101Z] Test passed after 2 failed attempts on dependabot/github_actions/actions/github-script-6.3.3.
[2022-10-21T15:18:27.628Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T15:36:40.095Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T15:43:51.593Z] Test passed after 2 failed attempts on trunk.
[2022-10-21T15:47:21.927Z] Test passed after 2 failed attempts on trunk.
[2022-10-21T15:52:42.663Z] Test passed after 1 failed attempt on prevent-nested-tags-in-code-block.
[2022-10-21T16:02:03.377Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T20:44:50.075Z] Test passed after 1 failed attempt on trunk.
[2022-10-21T22:16:02.049Z] Test passed after 2 failed attempts on tests/local-clone-2.
[2022-10-22T10:52:15.560Z] Test passed after 2 failed attempts on fix/misspelled-word.
[2022-10-22T18:52:30.523Z] Test passed after 1 failed attempt on patch-1.
[2022-10-22T20:52:17.443Z] Test passed after 1 failed attempt on tests/record-cpus-data.
[2022-10-23T05:21:52.300Z] Test passed after 1 failed attempt on try/list-view-modify-shortcut-focus.
[2022-10-24T01:13:04.456Z] Test passed after 2 failed attempts on trunk.
[2022-10-24T05:15:48.291Z] Test passed after 1 failed attempt on update/font-size-picker-slider.
[2022-10-24T06:41:55.106Z] Test passed after 1 failed attempt on form-fields.
[2022-10-24T07:26:51.224Z] Test passed after 1 failed attempt on try/add-sticky-position-as-part-of-layout.
[2022-10-24T09:23:51.979Z] Test passed after 1 failed attempt on trunk.
[2022-10-24T10:23:26.471Z] Test passed after 1 failed attempt on trunk.
[2022-10-24T11:05:00.106Z] Test passed after 2 failed attempts on add/inserter-media-tab.
[2022-10-24T11:27:04.491Z] Test passed after 1 failed attempt on form-fields.
[2022-10-24T12:30:58.194Z] Test passed after 2 failed attempts on migrate/site-editor-inserter.
[2022-10-24T12:31:51.412Z] Test passed after 1 failed attempt on add/block-pattern-category-descriptions.
[2022-10-24T13:03:19.781Z] Test passed after 2 failed attempts on refactor/TabPanel-exuahstive-deps.
[2022-10-24T13:13:49.146Z] Test passed after 1 failed attempt on fix/43660-separator-background-style-variation.
[2022-10-24T14:44:25.072Z] Test passed after 2 failed attempts on trunk.
[2022-10-24T15:03:06.846Z] Test passed after 2 failed attempts on trunk.
[2022-10-24T15:58:25.869Z] Test passed after 1 failed attempt on release/14.4.
[2022-10-24T17:30:54.780Z] Test passed after 1 failed attempt on tweak-button-color-focus-states.
[2022-10-24T17:55:57.745Z] Test passed after 1 failed attempt on tweak-button-color-focus-states.
[2022-10-24T19:21:51.278Z] Test passed after 2 failed attempts on update/color-palette-component-ts.
[2022-10-24T20:52:12.661Z] Test passed after 1 failed attempt on refactor/TabPanel-exuahstive-deps.
[2022-10-25T00:44:36.448Z] Test passed after 1 failed attempt on add-caption-gs-ui.
[2022-10-25T01:06:18.418Z] Test passed after 1 failed attempt on trunk.
[2022-10-25T02:39:27.105Z] Test passed after 1 failed attempt on fix/popover-deprecations.
[2022-10-25T02:49:19.321Z] Test passed after 2 failed attempts on fix/site-editor-body-background.
[2022-10-25T05:42:30.245Z] Test passed after 1 failed attempt on fix/visual-editor-permission-error.
[2022-10-25T05:42:49.560Z] Test passed after 1 failed attempt on update/simplify-font-size-picker.
[2023-10-04T13:48:44.068Z] Test passed after 1 failed attempt on try/debounce-rich-text-on-input.
Error: expect(received).toMatch(expected)

Expected pattern: /<figcaption.*?>Tested caption<\/figcaption>/
Received string:  "<!-- wp:gallery {\"linkTo\":\"none\"} -->
<figure class=\"wp-block-gallery has-nested-images columns-default is-cropped\"><!-- wp:image {\"id\":72,\"sizeSlug\":\"large\",\"linkDestination\":\"none\"} -->
<figure class=\"wp-block-image size-large\"><img src=\"http://localhost:8889/wp-content/uploads/2023/10/10x10_e2e_test_image_z9T8jK.png\" alt=\"\" class=\"wp-image-72\"/><figcaption class=\"wp-element-caption\">T</figcaption></figure>
<!-- /wp:image --></figure>
<!-- /wp:gallery -->"

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/gallery.spec.js:193:3
@getdave
Copy link
Contributor

getdave commented Mar 23, 2022

Interesting that this failed again. I'll take a look if it's still erroring on trunk tomorrow.

@glendaviesnz
Copy link
Contributor

@getdave I have a draft PR that will hopefully fix this, will try and get it finalised today.

@glendaviesnz
Copy link
Contributor

ah, I now see your other PR for this @getdave which you created after mine, will have a look at both and see if there is still something strange happening.

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Mar 23, 2022

@getdave it seemed like the Gallery link in the list view was a bit fussy about where the click landed, ie. in the browser it will only expand if you click on the expander span within the anchor tag. I have narrowed it down in this PR and seems to be passing more reliably

@getdave
Copy link
Contributor

getdave commented Mar 24, 2022

Yeh I noticed this as well. I ended up using keyboard to trigger the expansion. That's good that the test is passing better now. Thanks for working on it.

@getdave
Copy link
Contributor

getdave commented Mar 24, 2022

@glendaviesnz I merged #39687 which wraps the block name in a <span>. This invalidated your changes so I updated them with a new test helper which seems to do the job.

@getdave
Copy link
Contributor

getdave commented Apr 25, 2022

Hasn't failed for a while. Let's close and see if it reopens.

@getdave getdave closed this as completed Apr 25, 2022
@github-actions github-actions bot reopened this Oct 14, 2022
@Mamaduka
Copy link
Member

The test started failing more often recently.

@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 25, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
@github-actions github-actions bot reopened this Oct 4, 2023
@Mamaduka Mamaduka removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
4 participants