-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap title of block in <ListView>
in a span
#39687
Conversation
Size Change: +1 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Failing due to #39689 |
packages/block-editor/src/components/list-view/block-select-button.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment but this looks safe to merge
4c1cd86
to
7347442
Compare
Is there a plan to put the text wrapping thing in a separate PR? I think that's the part that's most interesting and it's what necessitates this change. |
Yes I will follow up with an option for text wrapping on ListView 👍 |
7347442
to
8963f3f
Compare
What?
Extracts changes from #39290 into this dedicated PR.
Wraps the title of the block shown within the list view in a
<span>
in order to afford the ability to target via CSS.Why?
Currently you cannot directly target the name of the block with CSS. This is sometimes necessary - for example in #39290 we needed to alter the alignment of the block name to accommodate the wrapping of long block titles. We were unable to do this until the span was added.
How?
Wraps the block title in a span with a classname.
Testing Instructions
<span>
.Screenshots or screencast