Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap title of block in <ListView> in a span #39687

Merged
merged 12 commits into from
Mar 24, 2022
Merged

Wrap title of block in <ListView> in a span #39687

merged 12 commits into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. Fix broken tests caused by addition of span wrap around title

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    7ab142f View commit details
    Browse the repository at this point in the history

  2. Fix e2e tests by improving xpath selection by strict text content

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    5edec0e View commit details
    Browse the repository at this point in the history

  3. Correct the index in order to select the last Column block correctly

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    a406e46 View commit details
    Browse the repository at this point in the history

  4. Select Gallery block in list view correctly

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    4262537 View commit details
    Browse the repository at this point in the history

  5. Fix another Gallery test list view block selection

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    d9fbe1b View commit details
    Browse the repository at this point in the history

  6. Wrap block title in span

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    aa1a655 View commit details
    Browse the repository at this point in the history

  7. Revise selector to abide by BEM

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    dfc9b4f View commit details
    Browse the repository at this point in the history

  8. Account for new span when selecting expander on Gallery node

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    5c97082 View commit details
    Browse the repository at this point in the history

  9. Update utility function to return the anchor node

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    8963f3f View commit details
    Browse the repository at this point in the history

  10. Update other util functions to use same selector

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    213dbc7 View commit details
    Browse the repository at this point in the history

  11. Add new e2e test helper

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c5be00c View commit details
    Browse the repository at this point in the history

  12. Use new helper

    @getdave
    getdave committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    d4d7795 View commit details
    Browse the repository at this point in the history