[Flaky Test] should always expand single line selection #39787
Labels
[Type] Flaky Test
Auto-generated flaky test report issue
Comments
github-actions
bot
added
the
[Type] Flaky Test
github-actions bot
referenced
this issue
Dec 16, 2022
* Migrate Font Size Picker tests to Playwright * Remove legacy tests * Open document settings before each test
github-actions bot
referenced
this issue
Dec 16, 2022
…46598) A defect introduced in #46018 led to the tag processor backing up one index too far after flushing its queued changes on a document. For most operations this didn't cause any harm because when immediately moving forward after an update, the `next_tag()` returned to the same spot: it was backing up to one position before the current tag instead of at the start of the current tag. Unfortunately, when the current tag was the first in the document this would lead the processor to rewind to position `-1`, right before the start of the document, and lead to errors with `strpos()` when it received out-of-bounds indices. In this fix we're correcting the adjustment for the HTML tag's `<` and documenting the math in the file so that it's clearer why it's there and providing guidance should another fix be necessary. As supporting work to this patch we're making the text replacement sort stable, inside the tag processor, for when determining the order in which to apply text replacements. This isn't necessary for the runtime but is a nuissance for testing because different PHP versions produce different unstable sort orderings and this prevents that from causing the unit tests to fail in one version but pass in another. Props to @anton-vlasenko for finding this bug. Enforce sort stability when flushing out text replacements
github-actions bot
referenced
this issue
Dec 20, 2022
…'s `raw_content.content` to an empty string if it's `undefined`" (#46600) * Revert "[`customize-widgets/utils/widgetToBlock`] Initialize a widget's `raw_content.content` to an empty string if it's `undefined` (#46487)" This reverts commit 271f650. * Guard against undefined content closer to parse() call
This was referenced Feb 23, 2023
github-actions bot
referenced
this issue
Feb 23, 2023
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
This was referenced Feb 23, 2023
This was referenced Feb 23, 2023
github-actions bot
referenced
this issue
Feb 23, 2023
* Update font origin to match updated API When fonts are converted to theme.json format, origin is set to `gutenberg_wp_fonts_api`. * Update font origin set in deprecated WP_Web_Fonts class --------- Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
This was referenced Feb 23, 2023
This was referenced Feb 24, 2023
github-actions bot
referenced
this issue
Nov 11, 2023
The Top Toolbar was relying on position: absolute; CSS and layoutEffect calculations to display the selected block tools visually within the top toolbar. This PR places it in the header DOM where we want it, allowing us to use native CSS and DOM flow to improve accessibility (tab order matches visual order) and have more maintainable code. * Imports `<BlockContextualToolbar />` via private-api and the <Popover /> for image captions to the edit site, edit post, edit widgets, and customize widget headers. * Removes position: absolute; and layoutEffect block toolbar positioning hacks. * CSS for the top toolbar to use flex-shrink and overflow-x: hidden; to allow for the block toolbar to fit its current space and scroll to reveal the hidden tools. * With top toolbar mode, Shift+Tab does not go directly to the toolbar but the first tabstop outside of the editor. Co-authored-by: Alex Lende <ajlende@gmail.com> Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.
Test title
should always expand single line selection
Test path
/test/e2e/specs/editor/various/multi-block-selection.spec.jsErrors
[2023-03-30T09:02:10.961Z]Test passed after 1 failed attempt ontry/footnotes-again.[2023-04-04T19:48:03.514Z]Test passed after 1 failed attempt ontry/block-tools-marry-document-tools.[2023-09-15T21:51:58.083Z]Test passed after 1 failed attempt ontry/rich-text-value-refactor.[2023-09-26T11:41:40.378Z]Test passed after 1 failed attempt ontry/debounce-rich-text-on-input.[2023-10-24T23:03:17.554Z]Test passed after 1 failed attempt ontry/block-edit-lazy-loading.[2023-10-25T10:49:43.585Z]Test passed after 1 failed attempt ontry/block-edit-lazy-loading.[2023-11-11T00:16:40.541Z]Test passed after 1 failed attempt ontrunk.The text was updated successfully, but these errors were encountered: