Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright: fix request utils for non Docker envs #48206

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Feb 17, 2023

What?

For non Docker installs theme activation fails: the path assumes the base URL to be simply the host while WP could be installed in a directory. It also assumes the theme won't be located in a subdirectory.
Extracting this out of #47907 to isolate test failures.

Why?

How?

Testing Instructions

Use MAMP: https://github.com/WordPress/gutenberg/blob/9a4b95e37da8b4c4b271f510895690a4ea1fa780/docs/contributors/code/getting-started-with-code-contribution.md#using-local-or-mamp

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link

github-actions bot commented Feb 17, 2023

Flaky tests detected in e6f0da3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4230101622
📝 Reported issues:

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Any idea how we can test this?

@kevin940726
Copy link
Member

I'm gonna just trust you on that then 😆 .

@ellatrix ellatrix enabled auto-merge (squash) February 21, 2023 07:14
@ellatrix ellatrix merged commit 3076405 into trunk Feb 21, 2023
@ellatrix ellatrix deleted the fix/test-utils-theme branch February 21, 2023 09:20
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Feb 21, 2023
@ntsekouras
Copy link
Contributor

I just cherry-picked this PR to the wp/6.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants