Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP files for Pull Requests are no longer made #40483

Closed
skorasaurus opened this issue Apr 20, 2022 · 4 comments
Closed

ZIP files for Pull Requests are no longer made #40483

skorasaurus opened this issue Apr 20, 2022 · 4 comments
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Regression Related to a regression in the latest release

Comments

@skorasaurus
Copy link
Member

skorasaurus commented Apr 20, 2022

Description

In #26746 ; build tooling was adopted so that a zip file of Gutenberg for every Pull request changes were created for each pull request.

The zip contains the gutenberg plugin built and ready for use,

  • This greatly lowers the barriers & obstacles for users to test out pull requests:
  • git and extensive configuration is no longer needed

To test out a pull a request, a user downloads the zip in their plugins directory, extract the folder and files, and activate the plugin; just like any other plugin.

I've noticed for some time that these are no longer being generated
(examples: #40410 #40136 #36590 #33496

and hadn't found any issues stating why this was removed.

Step-by-step reproduction instructions

  1. Visit any open pull request
  2. go towards bottom of pages where the builds, checks are occurring;
  3. read that the build zip was skipped
    image

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@skorasaurus skorasaurus added [Type] Build Tooling Issues or PRs related to build tooling [Type] Regression Related to a regression in the latest release labels Apr 20, 2022
@glendaviesnz
Copy link
Contributor

I am not sure why the jobs are showing as skipped on the likes of #40410, but the zip file is still available under the Checks tab:

zip.mp4

@talldan
Copy link
Contributor

talldan commented Apr 21, 2022

It's a bit confusing because there are multiple 'build plugin' jobs and some are skipped because they're only triggered as part of the actual release workflow. I'm not sure if there's a way to hide them given they're irrelevant for most PRs.

On all of those PRs linked there's still a 'Build Gutenberg Plugin Zip / Build Release Artifact (pull_request)' job that's required. It's near the bottom, and if you click 'Details' and then click 'Summary', the zip is available that way too:
Screen Shot 2022-04-21 at 11 00 20 am

Maybe there docs that can be updated to clarify this.

@skorasaurus
Copy link
Member Author

I am not sure why the jobs are showing as skipped on the likes of #40410, but the zip file is still available under the Checks tab:
zip.mp4

Thanks @glendaviesnz ; I didn't look there. I don't know whether this feature (getting zips of pull requests for easy testing!)
has been documented anywhere or where the best place would be to document this; maybe @ryanwelcher or @annezazu would have ideas; otherwise, I'll close this.

@stevebab
Copy link

@skorasaurus , you are a blessing. Thank you, it works beautifully. I wish we could get this into a "Gutenberg Settings" feature at some point, but this is is exactly what most of my agency's workload requires.
Now to figure out how to disable the "Download" button by default!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

4 participants