Styles: remove wp-editor from wp-edit-blocks dependencies #33496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aristath
approved these changes
Jul 19, 2021
|
Thanks for the reviews. I noticed we have styling for the post title in that package (a component that will be rendered in the iframe that is not a block), so we'll have to find a better place for it. |
|
Is there anything blocking us here? Or should we merge it? |
|
Was the post title styling fixed #33496 (comment) I guess that's the last blocker here. |
ellatrix
force-pushed
the
remove/wp-editor-dependency
branch
from
6c5b42c
to
40ab267
Compare
|
I moved the |
|
Size Change: -76 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
wp-edit-blocksstylesheet (in theblock-librarypackage) haswp-editorset as a dependency. As a result, this stylesheet is loaded in the editor content iframe, even though it shouldn't target components inside the editor content.To do: remove the title rules (and maybe component) from the package.
wp-editorhas thewp-nuxdependency, which will now also be removed from the iframe.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).