Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolsPanel: Selected ToolsPanel menu options are not persistent #41544

Open
apeatling opened this issue Jun 3, 2022 · 11 comments
Open

ToolsPanel: Selected ToolsPanel menu options are not persistent #41544

apeatling opened this issue Jun 3, 2022 · 11 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@apeatling
Copy link
Contributor

apeatling commented Jun 3, 2022

Prior: #41376

When using the ToolsPanel menu to select design tool options for a block, these selections are not remembered unless the value of a design tool setting has been selected. Simply setting the option as visible is not enough to persist it on block re-selection.

This GIF shows the issue:

2022-06-03 10 08 20

@apeatling apeatling added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jun 3, 2022
@apeatling apeatling moved this to ⏱ Not Started in Design Tools Project Jun 3, 2022
@apeatling
Copy link
Contributor Author

apeatling commented Jun 3, 2022

Persisting selected options has been discussed previously in #39561 (comment).

However this discussion was for persisting selected options across multiple blocks of the same type. That warrants caution, however persisting options in the same instance of a block is quite different. In my opinion this goes against user intent and expectation and should be added.

@mtias
Copy link
Member

mtias commented Jun 25, 2022

Curious how you'd expect it working after a reload — would you expect a non customized option you selected to show up? Holding onto the session state seems a bit superfluos to me, and I don't think it's worth the extra complexity of handling state that would persist through remounts but not through hard reloads.

@apeatling
Copy link
Contributor Author

apeatling commented Jul 5, 2022

I don't think it is necessary to maintain state after a reload.

However, within a single session, I can see it being a confusion. I can see a user selecting the tools they need, but in the middle selecting a similar block to refer to a setting value. Then they come back to the block to find everything reset.

I haven't run in to this in my real world usage, so it is purely hypothetical on my part -- but it has been reported in the original issue.

@mtias
Copy link
Member

mtias commented Sep 10, 2022

I'd consider this low impact for the likely complexity it'd entail to keep track of unmounted component state. We can revisit if it becomes a wider concern.

@annezazu
Copy link
Contributor

Re-opening this as it came up in a discussion with YouTubers with folks requesting this as an option. Specifically, that when an option is enabled that it persists in the future until someone disables it again for typography settings. I recorded a little video showing how this impacts my workflow with a specific example:

styling.options.typography.mov

Curious to hear from @WordPress/outreach as to whether this is something others run into.

@annezazu annezazu reopened this Aug 14, 2024
@markhowellsmead
Copy link

Definitely. See also #62064.

@bacoords
Copy link
Contributor

Big agree on this. There's a number of issues about the persistence of UI controls- it's a very common pain point for most users (There were some a11y concerns about some of them, but I believe they're addressable):

@annezazu
Copy link
Contributor

Thank you all for chiming in and cross connecting. Excellent to get a broader spread and more thoughts. Keep it coming!

@markhowellsmead
Copy link

There's some great UX feedback in this post on X. What's the best way to get these included here in Github?

https://x.com/KatieKeithBarn2/status/1824362828251201966

@annezazu
Copy link
Contributor

There's some great UX feedback in this post on X. What's the best way to get these included here in Github?

Open or find issues for each item :) Some of these already have issues opened.

@annezazu
Copy link
Contributor

annezazu commented Sep 5, 2024

Noting that this came up once more today on a WordPress freelancer online meetup with folks talking about how frustrating it is to go looking for an option, turn it on, and then have it disappear when you move away to work on another block causing you to have to repeat the search cc @techmagick as you were a part of that convo <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

5 participants