Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of tooltips text #4325

Closed
afercia opened this issue Jan 5, 2018 · 3 comments · Fixed by #4471
Closed

Consistency of tooltips text #4325

afercia opened this issue Jan 5, 2018 · 3 comments · Fixed by #4471
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@afercia
Copy link
Contributor

afercia commented Jan 5, 2018

Splitting this out from #4318

1
More related to design/consistency /cc @jasmussen : some tooltips have title-cased text, some not. Regardless of language-specific preferences (as far as I know title-case is preferred in English, but it's not in many other languages), there should be some consistency. Since these are tooltips and not button labels, I'd go for no title-casing. Some example of the current tooltips:

Insert block
Change block type
Align left
Move Up
Move Down
Edit Gallery
Edit image
Remove Image
Grid View
List View
Edit Table

2
When I insert an image, by default it has no link. However, the link button says "Edit link". In the classic editor, the link button always says "Insert/edit link" to avoid this issue.

@afercia afercia added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. labels Jan 5, 2018
@karmatosed
Copy link
Member

I would +1 to non title casing. Title casing has a lot of accessibility issues for reading variations.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jan 10, 2018
@ggwicz
Copy link

ggwicz commented Jan 15, 2018

@karmatosed Can you elaborate a bit on/provide examples of the accessibility issues you mention with title casing? I'm trying to find resources on that but am finding stuff about all-caps lettering, not title case per se.

@afercia
Copy link
Contributor Author

afercia commented Jan 16, 2018

It's a minor issue but screen readers tend to read out uppercase letters with a higher voice pitch, especially when reading a word one character at a time. Instead, all-caps word are a real issue. Unless it's recognized as an acronym, an all-caps word gets usually read out character by character. It happened recently on a project of the company I work for: ADD SITE -> [eɪ] [diː] [diː] site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants