Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Edit Link" to "Insert/edit link" on Image Block #4562

Closed
wants to merge 1 commit into from
Closed

Change "Edit Link" to "Insert/edit link" on Image Block #4562

wants to merge 1 commit into from

Conversation

rileybrook
Copy link

Description

PR is a copy change from "Edit Link" to "Insert/edit link" - within the toolbar for the Image Block.

2
When I insert an image, by default it has no link. However, the link button says "Edit link". In the classic editor, the link button always says "Insert/edit link" to avoid this issue.

This was one of two changes recommended by @afercia in #4325

Screenshot Examples of Changes

screen shot 2018-01-17 at 10 30 06 pm

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@rileybrook rileybrook closed this Jan 18, 2018
@rileybrook rileybrook deleted the update/edit-link-copy-image-block branch January 18, 2018 16:13
@rileybrook
Copy link
Author

rileybrook commented Jan 18, 2018

Travis-CI test failed because of dependancies error. Replaced with #4581 after fixing problems locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant