-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: enable option to publish pages #49873
Comments
Good issue. We need to unify this. One instinct we recently discussed was to create a new singular "Page creation modal" that would be possible to invoke from all these separate places — site editor, navigation block, from a Buttons block through the URL dialog, anywhere — creating a single experience for drafting/creating pages. The modal would:
I guess we could embrace this issue for said initiative. What do you say, @jameskoster? On a separate note, I would kindly encourage that we avoid using the term "browse mode" to describe the site view of the site editor. Actual browse mode (the ability to click buttons and links in the preview frame to naviagate to them) is shelved, but likely to return inside the edit view. |
For design I think that makes sense 👍 I suspect we need some more holistic technical insights around drafts / revisions for pages in the site editor, since everything is still template driven under the hood. We'll need this functionality when editing pages too (#49404). |
I'll roll with Site Editor for now and have updated the issue name but have been trying to use the technical project name as a signal to devs who have worked on this. Sounds like we need to get on the same page :D |
I mostly want to avoid the term "browse mode" suddenly becoming the defacto name, as it was mistakenly used in the PR 🙈 |
Here's a first draft at a design that tackles this. Essentially what we want is for a unified way to create pages (template creation should share DNA with this, but is to follow separately). This unified interface for page creation should serve a few roles:
In that light, shown here are the various places mentioned, where you could potentially invoke this interface: Each of these pages would then open the following modal: As a starting point this modal would have options to:
Clicking the draft button would close the dialog and keep you wherever you were when you clicked the button to add, whether inside the editor, or whether in the Site Editor > Navigation section (where the newly drafted page would show up). Related to #48456: another option would be for the "Draft" button to take you to the Site Editor > Navigation > [new page you drafted] detail page, which would give you options to further edit metadata, or perhaps use a future pattern building interface. Or, potentially that could be the future behavior of the Edit button. Thoughts? |
I like having a dedicated UI for drafting pages outside of the Link UI itself 👍 What I would say is that the views shown above for the link creation UI need to map back to design discovery on the Link Control Overview Issue. |
Yep, I used the same designs Saxon created in #49091 (comment), with minimal changes ("Draft a new page: Galeria" instead of "Draft a new page"). |
To clarify I a bit further, Saxon's mockups, notably this part: This is what you'd see when you click a link that already has a link, no? CC: @SaxonF |
I'm noting "Insert a block instead" option in this mockup. This could help us solve the problem we currently have in the Navigation block whereby clicking on the inserter will either:
Hopefully with your new design we can have a single flow that doesn't diverge like this as it's confusing for users (and contributors!). |
A thought from having met this issue in the latest call for testing. I got to say I think we need to sit down and discuss the general feature of adding a link to the Navigation block. Once again looking at the overall feature. Once again comparing it to the Classic Menu screen. Looking at what features are added and how these should be added. It just feels like things are missing and we need to go through how the UI/UX is presented for a general user. Perhaps a topic to bring up during a core editor meeting or having a design meeting. |
@paaljoachim I had the same feeling as did @richtabor. He and I sat down recently (away from Github) to run through all the flows we could find and came up with a set of fixes we think are required to make it easier. These are listed in the "Fix the flows" section of #50165. |
@richtabor Noting you've already seen this, but it seems like another candidate to add to the Link UI tracking issue maybe? Also CC: @jameskoster, could we simply add a section to the save modal (#49832), "Publish the following pages"? |
That could be an option. Another idea would be to work with status editing. Perhaps in the page details panel (which displays the status) (#50390) you can click it to edit. So if you want to publish a page you update the status then save. |
It is a helpful and good idea to focus on the page details panel and using that to publish pages. |
Both seem useful 👍 👍 |
In writing the next call for testing, I wanted to note how strange it is to be able to draft a page and then not have a clue how to publish it within the Site Editor, because the option doesn't exist yet 😅. I plan to still test it but these drop offs need to be addressed sooner rather than later. |
I think @SaxonF is working on this, but I am happy to jump in if he doesn't have time. |
Yep I'm working on it, thanks @jameskoster ! |
Started work here. Fields hooked up in a temp location. |
When creating new pages from a navigation block, you can create draft pages. However, within the site editor, there's no way to publish pages, despite being able to edit them directly. This relates to the prior issue reported here around confusion with the draft state: #49871 This was found as I was working on the next call for testing for the FSE Outreach Program.
The text was updated successfully, but these errors were encountered: