Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Link Control are only saved when using the "Save" button (for all fields). #50945

Closed
Tracked by #50890
getdave opened this issue May 25, 2023 · 0 comments · Fixed by #50668
Closed
Tracked by #50890

Changes to Link Control are only saved when using the "Save" button (for all fields). #50945

getdave opened this issue May 25, 2023 · 0 comments · Fixed by #50668
Assignees
@getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@getdave
Copy link
Contributor

getdave commented May 25, 2023 •
edited
Loading

Part of #50890.

Let's change the control so that if there are no changes to the values then:

  • the Save button is not active
  • you cannot submit the control with ENTER

This means that changes will only be persisted when submitting the change using either:

  • Save button
  • Hitting ENTER within a text field

Once this is complete we can follow up with #50947
@getdave getdave mentioned this issue May 25, 2023
Closed
8 tasks
@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label May 25, 2023
@getdave getdave self-assigned this May 25, 2023
@getdave getdave mentioned this issue May 25, 2023
Merged
@getdave getdave changed the title Save button is disabled unless there are changes made to any fields. Link Control - changes are only saved when using the "Save" button (for all fields). May 25, 2023
@getdave getdave changed the title Link Control - changes are only saved when using the "Save" button (for all fields). Changes to Link Control are only saved when using the "Save" button (for all fields). May 25, 2023
@getdave getdave mentioned this issue May 25, 2023
Closed
@getdave getdave mentioned this issue May 25, 2023
Merged
This was referenced Jun 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link Control require user to manually submit any changes WordPress/gutenberg
1 participant
@getdave