Use checkbox for Open in new tab within Link Control
#50961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
|
Size Change: -19.1 kB (-1%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e0b738d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5090508290
|
getdave
changed the title
Open in new tab within Link Control
|
As its only 1 test failing I pushed a quick fix so we can land this. @MaggieCabrera is following up with a much better test implementation using Playwright. |
3 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes Link Control to use a checkbox rather than a toggle switch for the
Open in new tabsetting.Part of #50890
Closes #50947
Why?
Specifically required as a result of #50945.
Also because the new UX requires it.
How?
Changes the component to checkbox. Corrects visual alignment.
Testing Instructions
Open in new tabsettingTesting Instructions for Keyboard
Screenshots or screencast