Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayfinder: Second round of commands #51502

Closed
17 of 19 tasks
richtabor opened this issue Jun 14, 2023 · 5 comments · Fixed by #52184
Closed
17 of 19 tasks

Wayfinder: Second round of commands #51502

richtabor opened this issue Jun 14, 2023 · 5 comments · Fixed by #52184
Labels
[Package] Commands /packages/commands [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Jun 14, 2023

Not all of these may be possible, but here's a list of what would be interesting to include based on context:

Site Editor, view & edit

  • Reset styles to default / Same action as pressing the "Reset to defaults" control in the Styles panel, actions menu Add global styles related commands #51637
  • Open style revisions / Same action as pressing the "X revisions" control in the Styles panel, actions menu Add global styles related commands #51637
  • Open custom CSS / Same action as pressing the "Additional CSS" control in the Styles panel, actions menu
  • Learn about Styles / Same action as pressing the "Welcome Guide" control in the Styles panel, actions menu Add global styles related commands #51637
  • View site in new tab / Same action as the "View site" control in the Site Editor

Site Editor, edit mode

  • Open styles panel / Opens the style panel on the right

Site Editor & Post Editor, edit mode

  • Open settings panel / Opens the block inspector settings panel
  • Toggle list view /
  • Toggle spotlight mode /
  • Toggle distraction free mode (related)
  • Toggle top toolbar / Sets the editor to use the top toolbar, if not already (and vise-versa)
  • Toggle code editor / Sets the editor to the code editor view, if not already (and vise-versa)
  • Editor preferences / Opens the "Preferences" modal from the top-level "Options" vertical ellipsis menu
  • Keyboard shortcuts / Opens the "Keyboard shortcuts" modal from the top-level "Options" vertical ellipsis menu
  • Manage Reusable blocks

Post Editor

  • Toggle fullscreen mode
  • Allow comments on this post (if disabled)
  • Disable comments on this post (if enabled)
  • View outline / Opens the List view > Outline sidebar
@richtabor richtabor added the [Type] Enhancement A suggestion for improvement. label Jun 14, 2023
@richtabor
Copy link
Member Author

cc @youknowriad

@youknowriad
Copy link
Contributor

I started adding some of these commands here #51637 (the first group above). I'd love for more folks to help adding commands because:

1- It's easy
2- The more persons try, the better feedback we get on the API...

@youknowriad
Copy link
Contributor

Allow comments on this post (if disabled)
Disable comments on this post (if enabled)

I think these two commands are a bit weird, in the sense that they actually make changes to the post, contrary to all the other commands listed above. I think it's fine to have them but maybe better for another issue with similar commands. It feels a bit random here.

@richtabor
Copy link
Member Author

I think it's fine to have them but maybe better for another issue with similar commands. It feels a bit random here.

Sure, that's fine. I was just thinking of different types of commands that would require varying methods of implementation, to help lay solid examples for other commands of this nature.

@ntsekouras
Copy link
Contributor

Should we make the open styles -> toggle styles sidebar? 🤔 If yes and we're not in edit mode, should we have a different command to only open styles?

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 30, 2023
@ntsekouras ntsekouras removed their assignment Jun 30, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Commands /packages/commands [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants