[Command center]: Add preferences and keyboard shortcuts commands #51862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +966 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
ntsekouras
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
reviewed
Jun 25, 2023
youknowriad
reviewed
Jun 25, 2023
ntsekouras
force-pushed
the
add/preferences-shortcuts-commands
branch
from
46a750c
to
63ea335
Compare
|
Flaky tests detected in 49786fd9cbdd08c46ab8327302d8ce2512c72983. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5378726782
|
youknowriad
reviewed
Jun 26, 2023
ntsekouras
force-pushed
the
add/preferences-shortcuts-commands
branch
2 times, most recently
from
5d878a6
to
1b13b8c
Compare
ntsekouras
force-pushed
the
add/preferences-shortcuts-commands
branch
from
1b13b8c
to
3f97290
Compare
youknowriad
reviewed
Jun 27, 2023
youknowriad
approved these changes
Jun 27, 2023
ramonjd
pushed a commit
that referenced
this pull request
Jun 28, 2023
…1862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels
|
I just cherry-picked this PR to the release/16.1 branch to get it included in the next release: 0ab057c |
ramonjd
removed
the
Backport to Gutenberg RC
tellthemachines
pushed a commit
that referenced
this pull request
Jun 28, 2023
…1862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels
|
I just cherry-picked this PR to the add/pre-beta1-bugfixes branch to get it included in the next release: bdc33c9 |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jun 28, 2023
* Restore sidebar in focus mode on Pattern click through in Browse Mode Library (#51897) Brings back #51492 * [Command center]: Add preferences and keyboard shortcuts commands (#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels * [Site Editor]: Fix `library` command path (#51837) * Updating social link attributes (#51997) * Try: Update template titles (#51428) * Update template titles * Fix typo Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> * Revert Index rename * "front page" -> "homepage" * Update 404 Page make more sense given the template appears in the Pages panel too. * Front Page * home title + description * Revert Home name change, and move compat files * separate code for wp versions * update tests --------- Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: ntsekouras <ntsekouras@outlook.com> * Update text color (#51965) * Modal: Add small top padding to the content so that avoid cutting off the visible outline when hovering items (#51829) * Site Editor: Fix focus cutoff in add template modal * Add padding-top to the modal content * Remove unnecessary padding-top * Remove unnecessary padding-top * Update changelog * Revert top padding from block patterns list * Revert top padding from block patterns list * Remove unnecessary changes * Remove unnecessary changes * Add CSS inline comment * Change padding metrics * Rest API: rename navigation fallback classes from WP_ to Gutenberg_ (#51959) * The `WP_REST_Navigation_Fallback_Controller` class has been committed to core and therefore results in a naming conflict and unit test failures. Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`. But we can conditionally load the file instead. * Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Block_Menu_Converter Load WP_REST_Navigation_Fallback_Controller dependencies in load.php * Renamed all 6.3 classes to have the Gutenberg_ prefix. This should avoid compat errors and hopefully some confusion later. * Also rename test files for completeness * Updated deprecation notices to refer to Gutenberg classes * Fix phpunit failures (#51950) * Fix phpunit failures * Add comment * Update comment with actual reason this fix works --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Robert Anderson <robert@noisysocks.com>
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…rdPress#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #51502
This PR adds the following commands to both site and post editor:
How
In order to open the modals programmatically I had to keep this information in the edit site store, so I added the respective selectors, actions, etc.. In post editor we already had this information in store
Testing Instructions
Optionsvertical ellipsis menu.Notes
There is currently a bug in. the logic of site editor commands in
edit mode, but it's going to be fixed in this PR by @youknowriad .