Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social links: updating class and style attributes #51997

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Social links: updating class and style attributes #51997

merged 1 commit into from
Jun 28, 2023

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 28, 2023 •
edited
Loading

What?

Escape social link class and style attributes.

Why?

Escape social link class and style attributes.

How?

Escape social link class and style attributes.

Testing Instructions

Tests should pass
Social link block should render correctly on the frontend, with all classes/styles

Screenshots

Editor

Screenshot 2023-06-28 at 11 03 23 am

Frontend

Screenshot 2023-06-28 at 11 03 17 am

@ramonjd ramonjd added [Type] Enhancement A suggestion for improvement. Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Block] Social Affects the Social Block - used to display Social Media accounts labels Jun 28, 2023
@ramonjd ramonjd requested a review from ajitbohra as a code owner June 28, 2023 00:55
@ramonjd ramonjd self-assigned this Jun 28, 2023
@ramonjd ramonjd added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jun 28, 2023
tellthemachines
tellthemachines approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tellthemachines tellthemachines merged commit c711e2a into trunk Jun 28, 2023
@tellthemachines tellthemachines deleted the update/social-links-attributes branch June 28, 2023 04:05
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 28, 2023
@ramonjd
Copy link
Member Author

ramonjd commented Jun 28, 2023

I just cherry-picked this PR to the release/16.1 branch to get it included in the next release: b2cdee8

ramonjd added a commit that referenced this pull request Jun 28, 2023
@ramonjd
Updating social link attributes (#51997)
b2cdee8
@ramonjd ramonjd removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jun 28, 2023
tellthemachines pushed a commit that referenced this pull request Jun 28, 2023
@ramonjd @tellthemachines
Updating social link attributes (#51997)
24e9d2e
@tellthemachines
Copy link
Contributor

I just cherry-picked this PR to the add/pre-beta1-bugfixes branch to get it included in the next release: 24e9d2e

@tellthemachines tellthemachines removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 28, 2023
tellthemachines added a commit that referenced this pull request Jun 28, 2023
@tellthemachines @getdave
@ntsekouras @ramonjd @jameskoster @alexstine @t-hamano @noisysocks
Cherry-pick pre-6.3 Beta 1 bugfixes (#52011)
7366294 
* Restore sidebar in focus mode on Pattern click through in Browse Mode Library (#51897)

Brings back #51492

* [Command center]: Add preferences and keyboard shortcuts commands (#51862)

* [Command center]: Add preferences and keyboard shortcuts commands

* update labels

* [Site Editor]: Fix `library` command path (#51837)

* Updating social link attributes (#51997)

* Try: Update template titles (#51428)

* Update template titles

* Fix typo

Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>

* Revert Index rename

* "front page" -> "homepage"

* Update 404

Page make more sense given the template appears in the Pages panel too.

* Front Page

* home title + description

* Revert Home name change, and move compat files

* separate code for wp versions

* update tests

---------

Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>
Co-authored-by: ntsekouras <ntsekouras@outlook.com>

* Update text color (#51965)

* Modal: Add small top padding to the content so that avoid cutting off the visible outline when hovering items (#51829)

* Site Editor: Fix focus cutoff in add template modal

* Add padding-top to the modal content

* Remove unnecessary padding-top

* Remove unnecessary padding-top

* Update changelog

* Revert top padding from block patterns list

* Revert top padding from block patterns list

* Remove unnecessary changes

* Remove unnecessary changes

* Add CSS inline comment

* Change padding metrics

* Rest API: rename navigation fallback classes from WP_ to Gutenberg_ (#51959)

* The `WP_REST_Navigation_Fallback_Controller` class has been committed to core and therefore results in a naming conflict and unit test failures.
Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`.
But we can conditionally load the file instead.

* Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Block_Menu_Converter
Load WP_REST_Navigation_Fallback_Controller dependencies in load.php

* Renamed all 6.3 classes to have the Gutenberg_ prefix. This should avoid compat errors and hopefully some confusion later.

* Also rename test files for completeness

* Updated deprecation notices to refer to Gutenberg classes

* Fix phpunit failures (#51950)

* Fix phpunit failures

* Add comment

* Update comment with actual reason this fix works

---------

Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Co-authored-by: James Koster <james@jameskoster.co.uk>
Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Robert Anderson <robert@noisysocks.com>
@swissspidy
Copy link
Member

get_block_wrapper_attributes already escapes attributes — why was this added, what am I missing?

@ramonjd
Copy link
Member Author

ramonjd commented Jun 28, 2023

get_block_wrapper_attributes already escapes attributes — why was this added, what am I missing?

Thanks for raising that.

It was flagged in the mad rush to get Beta 1 out, and was probably an oversight.

Will it cause any problems in the interim?

If it's going to cause a performance hit, or is generally seen to be a bug, the it's something we can revert after Beta 1 before the RC. I'll make a note to revert it and add to the Editor Tasks for 6.3 project board.

ramonjd added a commit that referenced this pull request Jun 28, 2023
@ramonjd
Revert "Updating social link attributes (#51997)"
16282c0 
This reverts commit c711e2a.
@ramonjd ramonjd mentioned this pull request Jun 28, 2023
Merged
ramonjd added a commit that referenced this pull request Jun 29, 2023
@ramonjd
Revert "Updating social link attributes (#51997)" (#52019)
95c4948 
This reverts commit c711e2a.
tellthemachines pushed a commit that referenced this pull request Jul 3, 2023
@ramonjd @tellthemachines
Revert "Updating social link attributes (#51997)" (#52019)
97e3acf 
This reverts commit c711e2a.
tellthemachines added a commit that referenced this pull request Jul 3, 2023
@tellthemachines @ellatrix
@aaronrobertshaw @glendaviesnz @talldan @t-hamano @jameskoster @getdave @Mamaduka @scruffian @kevin940726 @carolinan @jasmussen @draganescu @jsnajdr @ramonjd @ntsekouras @SaxonF @richtabor @noisysocks
Update/wp6 3 beta3 (#52234)
6774683 
* Footnotes: inscrease selector specificity for anchor (#52179)

* Patterns: Include template parts for custom areas in Uncategorized category (#52159)

* Fix custom patterns console error (#51947)

* Fix error with react list key with new custom patterns list in inserter

* Update placeholder key

* Add comment to explain the different keys

* Patterns: Fix missing custom patterns in patterns explorer (#51889)

* Add custom patterns to pattern explorer

* show custom patterns in the patterns explorer dialog

* remove changes from 51877

* Fix up use of async lists

* remove a bit of code duplication by adding a new hook

* add 51877 fix back to make testing easier

* Just assign the key value in one place

* Refactor the custom patterns to use the usePatternsState hook

* Fix use of async list

* Translate strings and remove unneeded fields from pattern object

* Try integrating unsynced patterns directly into pattern selectors (#51955)

* Include reusable blocks with an undefined sync status in inserter items

* Update docs

* Remove change to hover dependencies

---------

Co-authored-by: Daniel Richards <daniel.richards@automattic.com>

* i18n: Add context to the word "Filters" (#52198)

* Update home template icon (#52075)

* Centralise all permissions lookup in Link UI and enable (#52166)

* BlockRemovalWarningModal: Fix incorrect '_n' usage (#52164)

* Fix fetching Nav fallback ID flushing Navigation entity cache (#52069)

* Only flush the `getEntityRecords` cache if the fallback isn’t already in state

* Save the edited entity record to a const and then invert it to determine whether we should invalidate the recordds

---------

Co-authored-by: scruffian <ben@scruffian.com>

* Block Editor: Unify texts for Create pattern modal (#52151)

* Fix history back after entering edit mode from Patterns (#52112)

* Add template part icons to the library grid items (#51963)

* Patterns: Fix sidebar tab label (#51953)

* Patterns: Fix setting of sync status for fully synced patterns (#51952)

* Library: Reinstate manage all template parts page (#51961)

* Command Palette: fix incorrect path and snackbar message when template part is deleted (#52034)

* Command Center: Fix incorrect navigation when deleting template part

* removeTemplate: consider title type

* Drop-indicator: remove white border. (#52122)

* Make Navigation fallback selector private (#51413)

* Move selector to become private

* adds basic lock functionality

* remove useless lock-unlock file

* map private selectors to resolvers

* Unlock the other usage

* only create one fallback per session

* Fix core-data duplicate private opt-in

* Data: bind resolvers to selectors individually, support private selectors

---------

Co-authored-by: Andrei Draganescu <andrei.draganescu@automattic.com>
Co-authored-by: scruffian <ben@scruffian.com>
Co-authored-by: Jarda Snajdr <jsnajdr@gmail.com>

* Focus Mode: Use the symbol icon if a pattern is being edited (#52031)

* Footnotes: register meta field for pages (#52024)

* Fix unintentional toggling on of distraction free (#52090)

* replace toggle with set preference - because I don't read code properly it seems

* remove notification

* Revert "Updating social link attributes (#51997)" (#52019)

This reverts commit c711e2a.

* Update home template name (#52048)

* Removes unused call (#51988)

* Remove ability for user to toggle sync status after pattern creation (#51998)

* Fix disable DFM when opening styles command (#52165)

* Update custom patterns label to 'My patterns' (#51949)

* rename custom patterns to my patterns

* Add my patterns label to inserter and show at the top

---------

Co-authored-by: Daniel Richards <daniel.richards@automattic.com>

* Library: Add sync status to pattern details screen (#51954)

* Patterns: Rename Library to Patterns (#52102)

* [Library] Add lock icon for theme patterns (#51990)

* Add lock icon for theme patterns

* Change to class names

* Add aria-description

* Change wording

* Patterns: Use "detached" copy consistently (#51993)

* Editor initrial appender: Zero out margins in constrained layouts. (#52026)

* Update pattern creation modal in library (#51946)

* Fix missing snackbars in Library (#52021)

* Make the entire preview clickable in order to enter "edit" mode in focus mode (#51973)

* Page Content Focus: Add welcome guides (#52014)

* Page Content Focus: Add welcome guides

* Don't show when editor guide is active

* Just use regular accent/theme color in all guides

* slight copy change page guide

* Update components changelog

* Disable new guides in E2E tests

* Use s.w.org videos

---------

Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>

---------

Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com>
Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: James Koster <james@jameskoster.co.uk>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Co-authored-by: scruffian <ben@scruffian.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Carolina Nymark <myazalea@hotmail.com>
Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com>
Co-authored-by: Andrei Draganescu <andrei.draganescu@automattic.com>
Co-authored-by: Jarda Snajdr <jsnajdr@gmail.com>
Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Robert Anderson <robert@noisysocks.com>
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@ramonjd @sethrubenstein
Updating social link attributes (WordPress#51997)
791a228
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@ramonjd @sethrubenstein
Revert "Updating social link attributes (WordPress#51997)" (WordPress…
8ab45d1 
…#52019)

This reverts commit c711e2a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellthemachines tellthemachines tellthemachines approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc

Assignees

@ramonjd ramonjd

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ramonjd @tellthemachines @swissspidy