WP 6.3-beta4: not all patterns and categories listed in site editor

[bvlgn]

Description

In de site editor only very few of the regitered patterns and categories are listed.

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

No response

Environment info

WordPress: 6.3-beta4, with no other plugins besides de beta tester pluigin.
Twenty-Twenty-Three theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[bvlgn]

Maybe, also have a look at the console and notice the multitude of messages that are generated when you click on the various pattern categories.

[jordesign]

I can recreate this in testing as well. Patterns are still present in the inserter within the editor - but not in the Site Browser.

[annezazu]

@aaronrobertshaw since you've worked on this section. Adding to to do as this does feel like a departure from what was there in earlier versions/what's intended.

[ndiego]

For TT3, only the three patterns that appear have Inserter set to true. So I believe this is correct. All other patterns are intentionally hidden.

If you try and theme like Frost, which has all patterns enabled, they do show up.

[bvlgn]

Ah, that explains it.
But I suspect, this might be an area of confusing for other users too?

[mikachan]

#52633 may also help improve this, as this will allow all patterns to be listed in the Patterns section in the editor, even if they aren't categorised. The exception would be if the pattern sets Inserter to no/false (with the help of #52629).

[ndiego]

For TT3, only the three patterns that appear have Inserter set to true. So I believe this is correct. All other patterns are intentionally hidden.

I was incorrect above. The patterns that are not showing in TT3 do have Inserter: no but they are not displaying because they also do not have any assigned categories. As @mikachan mentions, #52633 and #52629 will resolve this.

[annezazu]

Ah ha. Closing this out then in favor of #52614 Happy to reopen if there's something I'm missing but want to keep this work consolidated at this point.