Show uncategorized patterns on the Editor > Patterns page #52633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Bug
|
Size Change: +99 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for putting this together @carolinan 👍
I've only been able to give the code a quick look over as I'm still AFK and dealing with patchy airport wifi, so take this review with a grain of salt.
Comment on lines
+15
to
+18
| defaultCategories.push( { | ||
| name: 'uncategorized', | ||
| label: __( 'Uncategorized' ), | ||
| } ); |
There was a problem hiding this comment.
The "uncategorized" category for template parts was changed to "General" as that was the previous labelling. In that feedback, it was mentioned that nowhere else in the UI used "Uncategorized", we might need to change it here as well.
cc/ @SaxonF
There was a problem hiding this comment.
Uncategorized is used in several places. For example, when a post does not have a category. It is not a term that is unfamiliar.
But I choose it here over "General" because "Uncategorized" is what is used in the pattern inserter.
I still feel that until these two interfaces "blend together" more and feel like one interface, the categories and the order the patterns are displayed in should match:
There was a problem hiding this comment.
It made sense to use General for template parts, because that is what is used in the block editor UI for template parts.
Comment on lines
104
to
105
| patterns = patterns.filter( | ||
| ( item ) => ! item.hasOwnProperty( 'categories' ) |
There was a problem hiding this comment.
The uncategorized patterns would still need to be filtered via the search term correct?
There was a problem hiding this comment.
Yes you are right, let me see if I can fix that 🤔
There was a problem hiding this comment.
I still don't understand why the search was limited to searching inside categories instead of across all.
This comment was marked as resolved.
This comment was marked as resolved.
|
Flaky tests detected in 31e1f4d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5571552318
|
|
At least for 6.3, I think "Uncategorized" makes the most sense. It's what we have been using in the Inserter since Patterns were introduced. Either way, this is a very important PR to get into 6.3. Thanks for working on it @carolinan! |
mikachan
reviewed
Jul 17, 2023
There was a problem hiding this comment.
This is working well for me!
In Twenty Twenty-Three, I can see a new category called 'Uncategorized':
Confirm that the list of theme patterns has a category called Uncategorized. ✅
Confirm that the number of items is correct ✅
Confirm that the correct patterns are showing when the category is selected. ✅
Confirm that the other categories and the search still work. ✅
Confirm that uneditable patterns shows as locked, not synced. ✅
I agree with @ndiego that "Uncategorized" makes the most sense for 6.3, as it's the term currently used in the Pattern inserter.
glendaviesnz
added
the
Backport to WP 6.7 Beta/RC
glendaviesnz
approved these changes
Jul 17, 2023
|
I just cherry-picked this PR to the update/second-round-RC1 branch to get it included in the next release: 530cd9e |
ramonjd
removed
the
Backport to WP 6.7 Beta/RC
westonruter
added a commit
that referenced
this pull request
Jul 18, 2023
* trunk: (36 commits) Use `_get_block_template_file` function and set $area variable. (#52708) Change Delete page menu item to Move to trash. (#52641) Search block: Enqueue view script through block.json (#52552) Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) Github workflow: add a PHP backport changes action (#52096) Add layout API documentation. (#52673) Show uncategorized patterns on the Editor > Patterns page (#52633) Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) Update locked pattern tooltips (#52497) Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) Use posts instead of template parts for navigation color tests (#52654) Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) Site Editor: Fix incorrect 'useSelect' usage (#52683) Update issue gardening automation with new label (#52173) i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) Post Content link color should not be applied to placeholder component links (#52367) [Mobile] Update toolbar icons and colors (#52336) Avoid copying global style presets via the styles compatibility hook (#52640) Show warning on removal of Post Template block in the site editor. (#52666) Backport tools: sort PRs to be cherry picked by merged/closed date (#52667) ...
ramonjd
added a commit
that referenced
this pull request
Jul 18, 2023
* Try restoring the site editor animation (#51956) * Try restoring the site editor animation * fix header animation * Remove accidental addition of layout prop * tidy up formatting * fix animate presence issue * Fix animation between sidebar view and distraction free edit view * Leave sidebar present and maintain canvas to sidebar animation The sidebar is necessary for routing on mobile so we have to maintain its presence in the DOM. Just hiding it isn't enough though, as it is still able to be reached with keyboard tabs and screen readers. Using the relatively new `inert` property disables the element from user interaction, so we add that when we don't want the sidebar to be shown. * Fix mobile view for pattern library On Mobile, the canvas mode wasn't being set to edit when using the pattern library. This updates it to use the showSidbar value instead, keeping it in sync with the inert setting. --------- Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com> * Change password input to type text so contents are visible. (#52622) * Iframe: Silence style compat warnings when in a BlockPreview (#52627) * Do not autofocus page title field in the Create new page modal dialog. (#52603) * Use lowercase p in "Manage Patterns" (#52617) * Remove theme patterns title (#52570) * Block editor store: also attach private APIs to old store descriptor (#52088) As a workaround, until #39632 is merged, make sure that private actions and selectors can be unlocked from the original store descriptor (the one created by `createReduxStore`) and not just the one registered in the default registry (created by `registerStore`). Without this workaround, specific setups will unexpectedly fail, such as the action tests in the `reusable-blocks` package, due to the way that those tests create their own registries in which they register stores like `block-editor`. Context: #51145 (comment) Props jsnajdr * Block removal prompt: let consumers pass their own rules (#51841) * Block removal prompt: let consumers pass their own rules Following up on #51145, this untangles `edit-site` from `block-editor` by removing the hard-coded set of rules `blockTypePromptMessages` from the generic `BlockRemovalWarningModal` component. Rules are now to be passed to that component by whichever block editor is using it. Names and comments have been updated accordingly and improved. * Site editor: Add e2e test for block removal prompt * Fix Shift+Tab to Block Toolbar (#52613) * Fix Shift+Tab to Block Toolbar * Add changelog entry * Show warning on removal of Post Template block in the site editor. (#52666) * Avoid copying global style presets via the styles compatibility hook (#52640) * i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) * Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) * Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save * Address feedback * Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) * Show uncategorized patterns on the Editor > Patterns page (#52633) * Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) * Pass the root client id into the reusable blocks menu * Check that clientIds array is defined * Make check for array item more specific * Search block: Enqueue view script through block.json (#52552) * Search block: Enqueue view script through block.json * Remove extra space * Use `_get_block_template_file` function and set $area variable. (#52708) * Use `_get_block_template_file` function and set $area variable. * Update packages/block-library/src/template-part/index.php Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> --------- Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> * Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) * Don't allow template part to be created on the Patterns page for non-block themes * Remove unnecessary theme directory name in E2E test * Change Delete page menu item to Move to trash. (#52641) * Use relative path internally to include packages in dependencies (#52712) * Spacing Sizes: Fix zero size (#52711) * DimensionsPanel: Fix unexpected value decoding/encoding (#52661) --------- Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Andrea Fercia <a.fercia@gmail.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> Co-authored-by: Haz <hazdiego@gmail.com> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Petter Walbø Johnsgård <petter@dekode.no> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the Patterns page in the Site Editor to include uncategorized patterns.
Closes #52614
Why?
Patterns without categories did not show on Editor > Patterns.
(Category is an optional parameter when registering patterns)
How?
Testing Instructions
Activate a block theme that includes patterns without a category, for example, Twenty Twenty-Three.
Go to Appearance > Editor > Patterns.
Confirm that the list of theme patterns has a category called Uncategorized.
Confirm that the number of items is correct
Confirm that the correct patterns are showing when the category is selected.
Confirm that the other categories and the search still work.
Confirm that uneditable patterns shows as locked, not synced.
Screenshots or screencast
Screen.Recording.2023-07-17.at.06.06.55.mp4