Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow for creating lists from text #539

Closed
mtias opened this issue Apr 28, 2017 · 21 comments
Closed

Flow for creating lists from text #539

mtias opened this issue Apr 28, 2017 · 21 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

Idea discussed with @jasmussen.

image

If you select text across multiple lines, a contextual "make a list out of these" button could appear next to the block switcher.

Clicking it would create a new list block with those items.

See comments for a mockup of how this could work.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 28, 2017
@jasmussen
Copy link
Contributor

To elaborate a bit, this might be particularly interesting in combination with the multi paragraph text block, #447. In this case, selecting items inside such a block and clicking the list block would "split the block".

@jasmussen
Copy link
Contributor

Here are two flow mockups for this.

Version 1: the list buttons are always visible:

version 1

Version 2: the list buttons are visible only when you've selected across lines:

version 2

In version 2, would we miss the inline formatting buttons?

@mtias
Copy link
Member Author

mtias commented May 2, 2017

I think these transformations should appear on the block switcher because I expect creating a list to split it into a separate block.

@jasmussen
Copy link
Contributor

jasmussen commented May 2, 2017

Chatted with Matías and we came up with this:

make a list

In this flow, the left most list and quote buttons show up only when you select multiple lines, and they show up in the spot where the block switcher sits.

Here's how a list block would look:

list

@jasmussen jasmussen added this to the Beta milestone May 16, 2017
@BoardJames
Copy link

If the list has indents what should the conversion from list to paragraph do?

@jasmussen
Copy link
Contributor

Probably okay to remove the indentation in the conversion then. We can always revisit if we find that too destructive.

@jasmussen jasmussen modified the milestones: May Week 4: Beta, May 29 to Jun 2, Beta, Beta, Nice To Have May 30, 2017
@jasmussen jasmussen modified the milestones: Beta 0.8.0, Beta, Nice To Have, Beta 0.6.0 Jul 5, 2017
@ellatrix
Copy link
Member

ellatrix commented Jul 8, 2017

@jasmussen @mtias Is this still relevant?

@jasmussen
Copy link
Contributor

Is this still relevant?

It is on a meta level.

I think we have many many aspects right with the editor in its current state. But one of the aspects I still think needs a little polish is cross-text-block actions like list or quote making. It might have to be punted, but I think it's worth keeping this open.

@mtias
Copy link
Member Author

mtias commented Jul 9, 2017

@iseulde we need to review transformations in general, both UI and technically. This falls under that. I feel it should be more contextual (if you select multiple lines you get option to create list, otherwise you don't).

@mtias mtias modified the milestones: Beta 0.7.0, Beta 0.6.0 Jul 24, 2017
@ellatrix
Copy link
Member

@matias So if you select multiple paragraphs, there should be a list option? Sounds like #1811 is a good start for that.

jasmussen added a commit that referenced this issue Aug 2, 2017
There has been discussion on the heaviness of the blocks. Initially this led us to having only the left border on hover. We added a full outline so as to better portray that a paragraph is a block.

However multi selection across blocks works well. If we can get it to work as well with keyboard shortcuts (and show list and quote options in a toolbar), aside from this addressing #539, it seems like there's less of a need for the block outlines to look so heavy.
@mtias mtias modified the milestones: Beta 0.8.0, Beta 0.7.0 Aug 2, 2017
@jasmussen
Copy link
Contributor

Here's a new mockup:

multi-select list making

In this situation, you get a new quick toolbar, one which works across blocks. @iseulde what do you think?

@ellatrix
Copy link
Member

ellatrix commented Aug 4, 2017

@jasmussen I thought we were going for the blue toolbar on top?

@jasmussen
Copy link
Contributor

I still like that blue toolbar, it's an option. If it's easier to implement like that, it's okay.

The mockup tries a quick toolbar instead, as it adds actions related to formatting.

@ellatrix
Copy link
Member

ellatrix commented Aug 4, 2017

Yes, I initially made it like this. I think we removed it because of the sticky toolbar problem (would be limited to the first block). Not sure how to solve that problem.

@jasmussen
Copy link
Contributor

Yes, I initially made it like this. I think we removed it because of the sticky toolbar problem (would be limited to the first block). Not sure how to solve that problem.

If it's easier to do in the blue toolbar for now, totally fine, especially since we're pondering a fixed toolbar in #2148.

Doing a little inspector surgery, if we can move the block controls to be a child of this div, then it can scroll across the blocks:

screen shot 2017-08-04 at 17 18 26

But if that's super complicated, totally fine to use the blue one.

@ellatrix
Copy link
Member

ellatrix commented Aug 4, 2017

@jasmussen Don't think that's true. It would scroll over all the blocks and not get fixed anywhere but the top and bottom of the editor.

@ellatrix
Copy link
Member

ellatrix commented Aug 4, 2017

We can wrap selected blocks in a div (easy with React I guess), but then all iframes will reload every time you multi select them.

@jasmussen
Copy link
Contributor

Sounds like we should try putting the buttons in the blue bar for starters, seeing if it's actually a good flow. Then we can iterate from there.

@fisicx
Copy link

fisicx commented Sep 20, 2017

So how do I highlight a group of paragraph blocks? I 've tried using a mouse and keyboard and I can only ever select one block. Gutenburg just won't left me select more than one. I've been putting the cursor to the left of a character, holding shift and using the arrow keys to find the last point for so long (since before WordPerfect 5.1) it was odd to suddenly not be able to do so.

If I can't select multiple blocks then I can't convert them into a list.

@ellatrix
Copy link
Member

@fisicx Does this work for you in the last version, 1.8.1?

@jasmussen
Copy link
Contributor

Although the flow can still be polished further, recent advancements in selecting across blocks and the addition of cross-block transformations, I'm going to close this one as addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

5 participants