-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow for creating lists from text #539
Comments
To elaborate a bit, this might be particularly interesting in combination with the multi paragraph text block, #447. In this case, selecting items inside such a block and clicking the list block would "split the block". |
I think these transformations should appear on the block switcher because I expect creating a list to split it into a separate block. |
If the list has indents what should the conversion from list to paragraph do? |
Probably okay to remove the indentation in the conversion then. We can always revisit if we find that too destructive. |
@jasmussen @mtias Is this still relevant? |
It is on a meta level. I think we have many many aspects right with the editor in its current state. But one of the aspects I still think needs a little polish is cross-text-block actions like list or quote making. It might have to be punted, but I think it's worth keeping this open. |
@iseulde we need to review transformations in general, both UI and technically. This falls under that. I feel it should be more contextual (if you select multiple lines you get option to create list, otherwise you don't). |
There has been discussion on the heaviness of the blocks. Initially this led us to having only the left border on hover. We added a full outline so as to better portray that a paragraph is a block. However multi selection across blocks works well. If we can get it to work as well with keyboard shortcuts (and show list and quote options in a toolbar), aside from this addressing #539, it seems like there's less of a need for the block outlines to look so heavy.
Here's a new mockup: In this situation, you get a new quick toolbar, one which works across blocks. @iseulde what do you think? |
@jasmussen I thought we were going for the blue toolbar on top? |
I still like that blue toolbar, it's an option. If it's easier to implement like that, it's okay. The mockup tries a quick toolbar instead, as it adds actions related to formatting. |
Yes, I initially made it like this. I think we removed it because of the sticky toolbar problem (would be limited to the first block). Not sure how to solve that problem. |
If it's easier to do in the blue toolbar for now, totally fine, especially since we're pondering a fixed toolbar in #2148. Doing a little inspector surgery, if we can move the block controls to be a child of this div, then it can scroll across the blocks: But if that's super complicated, totally fine to use the blue one. |
@jasmussen Don't think that's true. It would scroll over all the blocks and not get fixed anywhere but the top and bottom of the editor. |
We can wrap selected blocks in a div (easy with React I guess), but then all iframes will reload every time you multi select them. |
Sounds like we should try putting the buttons in the blue bar for starters, seeing if it's actually a good flow. Then we can iterate from there. |
So how do I highlight a group of paragraph blocks? I 've tried using a mouse and keyboard and I can only ever select one block. Gutenburg just won't left me select more than one. I've been putting the cursor to the left of a character, holding shift and using the arrow keys to find the last point for so long (since before WordPerfect 5.1) it was odd to suddenly not be able to do so. If I can't select multiple blocks then I can't convert them into a list. |
@fisicx Does this work for you in the last version, 1.8.1? |
Although the flow can still be polished further, recent advancements in selecting across blocks and the addition of cross-block transformations, I'm going to close this one as addressed. |
Idea discussed with @jasmussen.
If you select text across multiple lines, a contextual "make a list out of these" button could appear next to the block switcher.
Clicking it would create a new list block with those items.
See comments for a mockup of how this could work.
The text was updated successfully, but these errors were encountered: