Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support two align variations: "full-width" and "wide". #546

Closed
mtias opened this issue Apr 28, 2017 · 11 comments
Closed

Support two align variations: "full-width" and "wide". #546

mtias opened this issue Apr 28, 2017 · 11 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Priority] High Used to indicate top priority items that need quick attention [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

Instead of single setting for full bleed images, it can be a "stepped" control—wide, wider, fullwidth. It needs some design work for the UI. It can work really well with galleries and hero-image.

@mtias mtias added [Feature] Blocks Overall functionality of blocks Design [Type] Enhancement A suggestion for improvement. labels Apr 28, 2017
@jasmussen
Copy link
Contributor

Here are two approaches. The one literally has steps (design input appreciated, this configuration doesn't feel optimal):

image neutral

image selected

image wide

image fullwidth

Alternately, we add another button to the toolbar:

screen shot 2017-05-01 at 14 01 19

👆 From left to right, that's float left, center, float right, wide, full-width.

@karmatosed
Copy link
Member

karmatosed commented May 2, 2017

Would the button in toolbar appear just for images? We are training people UI wise to expect actions in the toolbar, so we should as a result not change that with this UI.

@jasmussen
Copy link
Contributor

Would the button in toolbar appear just for images?

With very few exceptions (I think List might not have any alignments in the first version) we'd have only two types of alignments: text alignments (for text specific blocks) and block level block level alignments, which you see here.

We are training people UI wise to expect actions in the toolbar, so we should as a result not change that with this UI.

Can you elaborate?

@karmatosed
Copy link
Member

Can you elaborate?

It depends where the placing is. We seem to have a training of:

  • Interact with block
  • Action toolbar (for want of better word) appears

If we follow that then it makes sense.

I may just need to see this in prototype as assuming from the images.

@jasmussen
Copy link
Contributor

Here's a blueprint for the various terms we've dubbed.

The toolbar docked to the block is the Quick Toolbar, and the button that would control alignment would be the Block Level Formatting group. In the blueprint it shows block level formatting for text, i.e. text alignments. But for any other block, image included, this would instead show layout alignments, like float left, center, right, wide, full width.

This was referenced May 9, 2017
@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@jasmussen jasmussen removed this from the May Week 4: Beta milestone May 22, 2017
@jasmussen
Copy link
Contributor

@mtias having thought about this for a long time now, I think the best we can do here is add the extra icon:

It's the least mystery meat of all the solutions I've explored, and it keeps the behavior or the buttons to simply be toggles, not steppers. What do you think? I can add the dashicon real quick, then perhaps we can get in the full-bleed branch soon also?

@mtias
Copy link
Member Author

mtias commented Jun 2, 2017

And this one would be an intermediary step wide instead of full-wide which the theme would handle?

image

@jasmussen
Copy link
Contributor

Yes, that step would be wide, and

screen shot 2017-06-02 at 12 10 26

would be full-wide

@mtias
Copy link
Member Author

mtias commented Jun 2, 2017

Sounds good.

@jasmussen
Copy link
Contributor

New icon upstream in Dashicons: WordPress/dashicons#191

jasmussen added a commit that referenced this issue Jun 2, 2017
This PR updates Dashicons, and adds a new full-width icon. This renames the old icon to "wide". See also discussion in #546
@mtias mtias self-assigned this Jun 2, 2017
@jasmussen jasmussen modified the milestone: Beta Jun 5, 2017
@mtias mtias changed the title "Full-bleed" or "wide" can have steps Support to align variations: "full-width" and "wide". Jun 6, 2017
@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take and removed [Type] Enhancement A suggestion for improvement. labels Jun 6, 2017
@mtias mtias changed the title Support to align variations: "full-width" and "wide". Support two align variations: "full-width" and "wide". Jun 6, 2017
@mtias mtias added the [Priority] High Used to indicate top priority items that need quick attention label Jun 6, 2017
@jasmussen
Copy link
Contributor

This is fixed in master now! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Priority] High Used to indicate top priority items that need quick attention [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants