Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: The correct action menus are not displayed for patterns and template parts #61787

Closed
t-hamano opened this issue May 20, 2024 · 3 comments
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

t-hamano commented May 20, 2024

Description

On the Patterns page, the DataView's action dropdown displays unexpected action menus or expected action menus are missing.

Step-by-step reproduction instructions

The following are unnecessary actions as far as I've researched.

Patterns bundled with themes

image

Patterns bundled with themes should only be allowed to be duplicated. The following three actions should not be displayed because they cause unintended behavior.

  • Edit: The editor canvas opens, but with the template instead of the selected pattern.
  • Rename: The message Patterns bundled with themes should only be allowed to be duplicated. is displayed.
  • Move to Trash: The action is executed, but the pattern is not removed (and of course it shouldn't be).

User-created patterns

image

"Move to trash" is not necessary because the "Delete" menu already exists.

User-created template parts

image

The following actions are missing:

  • Rename
  • Delete

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Regression Related to a regression in the latest release [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 20, 2024
@t-hamano t-hamano changed the title DataViews: Pattern spage contains unnecessary actions DataViews: The correct action menus are not displayed for patterns and template parts May 20, 2024
@jameskoster
Copy link
Contributor

Just noting that the extraneous 'Move to trash' action on patterns also appears in the Inspector:

Screenshot 2024-05-20 at 16 55 00

@ntsekouras
Copy link
Contributor

ntsekouras commented May 22, 2024

I'll take a look into this.

@ntsekouras
Copy link
Contributor

Closing this as I think it's fully fixed with this last PR. Feel free to reopen if I've missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants