Consolidate and fix delete and edit post actions
#61912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
Mamaduka,
youknowriad and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -494 B (-0.03%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
May 23, 2024
youknowriad
reviewed
May 23, 2024
|
Flaky tests detected in 2278e5f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9211373676
|
t-hamano
reviewed
May 24, 2024
t-hamano
approved these changes
May 24, 2024
There was a problem hiding this comment.
As far as I've tested, everything is working as expected.
One slight concern is that the "Move to Trash" has been changed to "Delete" in posts and pages. Some users may be confused as to whether the new "Delete" text, which previously read "Move to Trash," means "Move to Trash" or "Delete Permanently".
By the way, a "Delete Permanently" action may be added in the future, right?
There is one already, but the only way to access that action is through the pages list in |
I agree, this may be confusing. Deleting a post doesn't actually delete it, but moves it to the trash where it may be recovered; I do think that's an important distinction. For items that cannot be recovered, "Delete" is fine, but for items that can be, I think using "Move to Trash" is expected. |
|
It seems there is no correlation between the ability to trash posts and how the post type is registered, so I'll keep two separate actions for now. One for template, patterns and template parts, and one for all other posts. |
ntsekouras
force-pushed
the
consolidate-delete-post-action
branch
from
f2b1139
to
ddc727c
Compare
t-hamano
reviewed
May 27, 2024
| @@ -202,7 +313,7 @@ const trashPostAction = { | |||
| disabled={ isBusy } | |||
| __experimentalIsFocusable | |||
| > | |||
| { __( 'Delete' ) } | |||
| { __( 'Trash' ) } | |||
There was a problem hiding this comment.
Suggested change
| { __( 'Trash' ) } | |
| { __( 'OK' ) } |
I think "OK" is easier to understand, just like in WP6.5, what do you think?
WP6.5
This PR
jorgefilipecosta
approved these changes
May 27, 2024
Mamaduka
approved these changes
May 27, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
youknowriad
reviewed
Jun 27, 2024
| TEMPLATE_ORIGINS.custom | ||
| ) && | ||
| ! template.has_theme_file && | ||
| ! template.templatePart?.has_theme_file |
There was a problem hiding this comment.
I don't understand why the template part object is actually template.templatePart and not just template?
There was a problem hiding this comment.
In patterns list page we map the templates parts to a different object than the one returned from the endpoint. This is why we need to check two props.
There was a problem hiding this comment.
Can we avoid mapping and just return the right objects?
There was a problem hiding this comment.
I encountered the same issue when fixing a bug for the "Reset" action - #62951. The fact that action might receive differently shaped objects when viewing a single or list of entities can be confusing.
There was a problem hiding this comment.
I'm fixing that in #62927
There was a problem hiding this comment.
Can we avoid mapping and just return the right objects?
Probably.. I hadn't implemented that and will check your PR @youknowriad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #61787
Similar to: #61857
This PR does two things:
editaction in site editor to be shown only in user patterns.deletepost action and keep onedeleteaction for templates, template parts and patterns, and onemove to trashaction for the rest post types.Notes
I've updated the messages when removing a template, template part, pattern to have the generic
itemlabel, to simplify the logic there. For single item deletions nothing changes because we use the name of the item. It changes though for multiple items and for example theAn error occurred while deleting the templates.is nowAn error occurred while deleting the items.Testing Instructions
patterns, pages and templates. In patterns it should be shown only for user created patterns and all template parts