Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wp-admin: latest Gutenberg styles adds extra padding to select boxes and create visual issue with Chrome #6326

Closed
optimizewp opened this issue Apr 20, 2018 · 2 comments
Closed

wp-admin: latest Gutenberg styles adds extra padding to select boxes and create visual issue with Chrome #6326

optimizewp opened this issue Apr 20, 2018 · 2 comments
Assignees
@jasmussen
Labels
[Type] Bug An existing feature does not function as intended

Comments

@optimizewp
Copy link

optimizewp commented Apr 20, 2018 •
edited
Loading

Issue Overview

wp-admin: latest Gutenberg styles (v 2.7.0) adds extra padding to select boxes and create visual issues with Chrome (For Windows 64 bit)

Steps to Reproduce (for bugs)

WP 4.9.5 and 5.0-alpha-42993
Theme: Gutenberg (same issue with other Themes)

  1. Login wp-admin
  2. Edit a post/page/product/cpt

Expected Behavior

Select boxes render well with FireFox, Edge, Safari and Chrome for Mac.

Gutenberg v. 2.7.0 on Firefox Latest Version (same on Nigthly)

image

Gutenberg v. 2.6.0 renders well on Chrome (latest version and Canary)

image

Visual Issue

Looks trunk with Chrome (Windows), latest version and Canary (Windows).

image

Possible Solution

Restore the padding to 2px
@StaggerLeee StaggerLeee mentioned this issue Apr 20, 2018
Closed
@jasmussen jasmussen self-assigned this Apr 20, 2018
@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Apr 20, 2018
@jasmussen
Copy link
Contributor

Thanks for the report. I'll take this one.

@pento pento mentioned this issue Apr 21, 2018
Closed
2 tasks
@gziolo
Copy link
Member

gziolo commented Apr 23, 2018 •
edited
Loading

A similar issues reported by @StaggerLeee:

Hi @jasmussen. Notice Title of Article. I did not touch it. Is there any smart way to prevent look like this ? Does not look very professional.

jasmussen pushed a commit that referenced this issue Apr 23, 2018
Fix select box regression.
fdef447 
Fixes #6326.

This "undoes" a change to the select box styling, and polishes the focus style as well.

The regression was to introduce a padding change that conflicted with upstream select box styles. This essentially reverts that. This also polishes the focus styles a bit.
@jasmussen jasmussen mentioned this issue Apr 23, 2018
Merged
jasmussen added a commit that referenced this issue Apr 30, 2018
@jasmussen
Fix select box regression. (#6350)
eabcb9b 
Fixes #6326.

This "undoes" a change to the select box styling, and polishes the focus style as well.

The regression was to introduce a padding change that conflicted with upstream select box styles. This essentially reverts that. This also polishes the focus styles a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gziolo @jasmussen @optimizewp