Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to set the homepage in the site editor #63666

Closed
jameskoster opened this issue Jul 17, 2024 · 7 comments · Fixed by #65426
Closed

Provide a way to set the homepage in the site editor #63666

jameskoster opened this issue Jul 17, 2024 · 7 comments · Fixed by #65426
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Jul 17, 2024

Currently to change the homepage you have to exit the site editor and navigate to reading settings which is quite disruptive.

A simple / lightweight method for setting the homepage in the site editor could be a nice enhancement.

Utilise the page actions menu

In both data views and the page Inspector there is an actions menu which could house a shortcut to set the homepage.

homepage

Related: #20338

@jasmussen
Copy link
Contributor

This seems like a fairly straight-forward way to do it. I'd assume, per the separate issue we have for this, that this menu item would also be available in the ⌘K command palette? What happens when you press "Confirm", does the document get marked as "dirty", and you can then actually confirm the change in the multi-entity saving flow? What might that look like?

@jameskoster
Copy link
Contributor Author

I'd assume, per the separate issue we have for this, that this menu item would also be available in the ⌘K command palette?

This is a bit of a tangent, but I'd expect to see this menu alongside shortcuts to other recently edited pages. We need better organisation in the command palette UI to achieve this. Here's an original mockup from way back:

Screenshot 2024-08-28 at 15 37 00

What happens when you press "Confirm"

That's a good question. The other actions in this menu are applied instantly, so I'd probably expect the same for this one.

@jasmussen
Copy link
Contributor

The other actions in this menu are applied instantly, so I'd probably expect the same for this one.

Setting a homepage feels a bit like setting a site logo, which does not happen instantly. But perhaps the name can be different from "Confirm"?

@jameskoster
Copy link
Contributor Author

Yup, it's not a strong feeling. I don't mind storing as a pending change.

But perhaps the name can be different from "Confirm"?

There is a growing tendency for the button label in such dialogs to echo the action. For instance in the "Move to trash" dialog the primary button is "Trash". Following that convention would give us something like "Set homepage" here, which seems a little long, but might work?

It would be good to define this detail more concretely in the systems work cc @mattrwalker.

@mtias
Copy link
Member

mtias commented Sep 7, 2024

While a bit hidden, it seems better than completely absent :)

@creativecoder
Copy link
Contributor

Note that there's a draft PR for this here: #65426

@mikachan mikachan self-assigned this Oct 7, 2024
@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Oct 22, 2024
@jasmussen
Copy link
Contributor

Since this is a good improvement, since it's in progress already, removing the feedback label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants