Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block-based themes: what happens to Reading Settings? #20338

Open
nickcernis opened this issue Feb 20, 2020 · 9 comments
Open

Block-based themes: what happens to Reading Settings? #20338

nickcernis opened this issue Feb 20, 2020 · 9 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@nickcernis
Copy link
Contributor

Block-based themes and full-site editing seem to make several Reading Settings less useful (or more confusing, perhaps):

Screen Shot 2020-02-20 at 17 15 09

Your homepage displays

Would the user now decide what's on their homepage via a block template, instead of with this setting? It's not currently possible to build a block template that honors this setting, as far as I can see.

Blog pages show at most

Would this now be set in a block template for a blog page as the “number of items” parameter in a query block? (Same with archives.)

Again, at present I couldn't find a way to use this value in block templates.

Feed and search engine settings

  • Syndication feeds show the most recent
  • For each post in a feed, include
  • Search Engine Visibility

These seem like they could survive, as they don't have block-based equivalents unless the settings move to a global panel in the Site Editor.

@mtias
Copy link
Member

mtias commented Aug 24, 2020

Initial thoughts are that when the query block is used in a template inheriting the global query (that is, not as a custom query), it should definitely reflect the main reading settings and allow changing those settings directly. It might turn out that controlling the query through the template and block settings becomes generally more intuitive to users.

@mtias mtias added the [Block] Query Loop Affects the Query Loop Block label Aug 24, 2020
@ntsekouras
Copy link
Contributor

ntsekouras commented Oct 9, 2020

Blog pages show at most

This has been implemented for Query block here: #25674

@jameskoster
Copy link
Contributor

jameskoster commented Jul 21, 2022

For the front-page template could we potentially bring some of the reading settings into the Inspector?

Screenshot 2022-07-21 at 11 40 47

@mtias
Copy link
Member

mtias commented Sep 10, 2022

@jameskoster that makes a lot of sense to me. I can also see it being useful for templates that inherit query to be able to manage some reading settings like posts per page, etc, from there.

@ntsekouras ntsekouras removed the [Status] In Progress Tracking issues with work in progress label Oct 12, 2022
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 16, 2023
@youknowriad
Copy link
Contributor

I think these settings are now editable and reflected in the site editor. I'm closing this issue, please reopen if I'm missing anything.

@jameskoster
Copy link
Contributor

@youknowriad not yet I'm afraid. The designs here are still relevant, and align with the latest work in #36951.

@jameskoster jameskoster reopened this Aug 16, 2023
@scruffian
Copy link
Contributor

What do you think about totally hiding reading settings for block themes?

@jameskoster
Copy link
Contributor

Probably worth discussing. Communicating the interaction between reading settings, templates (Front Page and Home in particular), page contents etc. in the UI makes for a quite overwhelming experience.

It would be much simpler to just select a page in the Site Editor's Pages panel and say; "This is my homepage".

@skora-cpl
Copy link

more conversation about this is happening at #64620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

10 participants