Update and move some Query filters #25674
Conversation
ntsekouras
added
[Feature] Full Site Editing
[Block] Query Loop
ntsekouras
requested review from
ajitbohra,
Soean and
talldan
as code owners
|
Size Change: +532 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
ntsekouras
requested review from
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
ntsekouras
requested review from
chrisvanpatten,
ellatrix and
youknowriad
as code owners
|
@ntsekouras Haiii! Thanks for looping me into this one. I can see where you had some trouble with the CSS alignment/widths for these controls x labels. Short note:
I've made some updates to the base Lastly, spacing for controls have always been determined with Ideally, you should not have to write custom Longer notes: The coupling of labels and controls within Gutenberg's input-based components are too tightly coupled. This leads to either awkward or limited alignment and width styling (both of which you experienced). Ideally, the widths and alignment for these controls should be standardized, following some sort of grid-based layout (predetermined by the UI system). For advance/custom use cases, the individual "parts" (e.g. |
There was a problem hiding this comment.
Tested code and confirmed it works.
I did have trouble with an FSE theme and got the This block has encountered an error and cannot be previewed. error on the site-editor screen, but I suppose that is OK?
Since FSE is experimental and this block is also experimental and only available when the FSE experiment is enabled, we don't really have to worry about backwards-compatibility.
Code looks good to me 👍
|
Hey @aristath - thanks for reviewing.
Do you mean with a previous existed query block? I'd like to have a look at it.
Yes, I think we are okay, since there is going to be a lot of changes soon in Query block. |
The issue was in the query block I had in my theme's <!-- wp:query {"queryId":1,"query":{"perPage":10,"offset":0,"orderBy":"date"}} -->
<!-- wp:query-loop -->
<!-- wp:post-title {"isLink":true,"linkTarget":"_self"} /-->
<!-- wp:post-content /-->
<!-- /wp:query-loop -->
<!-- wp:query-pagination /-->
<!-- /wp:query --> |
Description
Based on many iterations for Query block design here: #25198 and slack channels etc, it seems that filtering will end up in the inspector controls. Although the final design has not yet been found and approved, I think it makes sense to move some of the options we already have in the inspector control to make the Query toolbar less crowded.
This PR also makes a couple of changes.
templateused in Query block from [PostTile, PostContent] to [PostTitle, PostDate, PostExcerpt] that seems to make more sense IMO.tags and categoriesto show the input control.posts per pageandoffsetinNumberControls.posts_per_pagenumber from options.Checklist: