Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Editor Preferences" and "Keyboard shortcuts" commands don't work #64004

Closed
2 tasks done
t-hamano opened this issue Jul 26, 2024 · 0 comments · Fixed by #64019
Closed
2 tasks done

"Editor Preferences" and "Keyboard shortcuts" commands don't work #64004

t-hamano opened this issue Jul 26, 2024 · 0 comments · Fixed by #64019
Assignees
Labels
[Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jul 26, 2024

Description

I found that in both the post editor and site editor, running the following two commands did not launch the dialog:

  • Editor Preferences
  • Keyboard shortcuts

Both commands launch a modal dialog. This is very strange, but I found that it happens when StrictMode is enabled.

Namely, the following parts. When I turn off StrictMode, these two commands work again.

root.render(
<StrictMode>
<Layout
settings={ settings }
postId={ postId }
postType={ postType }
initialEdits={ initialEdits }
/>
</StrictMode>
);

root.render(
<StrictMode>
<App />
</StrictMode>
);

Step-by-step reproduction instructions

  • Launch the command palette.
  • Run "Editor Preferences" or "Keyboard shortcuts"

Screenshots, screen recording, code snippet

eccfc1659f774e00adae86d1027dbe80.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Commands /packages/commands labels Jul 26, 2024
@t-hamano t-hamano changed the title "Editor Ppreferences" and "Keyboard shortcuts" commands don't work "Editor Preferences" and "Keyboard shortcuts" commands don't work Jul 26, 2024
@Mamaduka Mamaduka self-assigned this Jul 27, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants