Try: Re-enable React StrictMode #61943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +65 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The e2e run with |
youknowriad
reviewed
May 24, 2024
youknowriad
approved these changes
May 24, 2024
|
Thanks @Mamaduka! I'd love to do some more thorough testing early next week, but if y'all are confident, go for it. |
|
As you can see, some e2e tests are failing when they're run in development and strict mode. This probably means we've subtle bugs in effects or anything that runs twice in |
Sounds familiar 😅 |
|
Technically, I guess we can merge this since it doesn’t affect production apps. Then create a separate tracking PR, where we try to fix each failure. Just like we do for React Compiler. What do you think? |
|
Yeah, since these bugs are actually already on trunk. I'm ok with merging. The downside is that some folks might start noticing the bugs in their dev environments and wonder what's happening. |
|
Actually, let's not merge this in 6.6 (unless we fix all the bugs). |
|
Sounds good. I’ll keep temp commit and we can use this as tracking PR. |
Mamaduka
added
the
[Status] Blocked
Mamaduka
force-pushed
the
try/enable-react-strict-mode
branch
from
2a60f04
to
6af9be8
Compare
This was referenced May 28, 2024
|
I started fixing the dev environment bugs. The "good news" is that some failures have related causes (e.g., #62053). |
Mamaduka
force-pushed
the
try/enable-react-strict-mode
branch
from
6af9be8
to
e2ef5ae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Mamaduka
force-pushed
the
try/enable-react-strict-mode
branch
from
bd472a3
to
d723b04
Compare
|
This is ready to be merged, but we will do it after this week's RC. It is probably not worth adding this as a minute change to WP 6.6. |
tyxla
reviewed
May 31, 2024
tyxla
approved these changes
May 31, 2024
So, just rebase on top of the latest trunk, or are there any additional fixes required? |
Yes, just rebasing fixes it. |
Mamaduka
force-pushed
the
try/enable-react-strict-mode
branch
from
d791fb6
to
50117db
Compare
|
Flaky tests detected in 50117db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9317959370
|
kevin940726
approved these changes
Jun 4, 2024
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
|
It looks like this change caused a regression in the customizer's widget editor (reported in #62898). Just sharing here in case anyone has an idea for how to fix it? I wasn't sure if it was safe to revert the |
|
Strangely, two commands seem to no longer work when |
Mamaduka
removed
the
[Status] Blocked
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR re-enable React StrictMode for editors. It was removed in #47701 and never restored.
Why?
Bugs Discovered
Testing Instructions
Testing Instructions for Keyboard
Same.