Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed blocks: adding captions via toolbar #64385

Closed
simison opened this issue Aug 9, 2024 · 2 comments · Fixed by #64394
Closed

Embed blocks: adding captions via toolbar #64385

simison opened this issue Aug 9, 2024 · 2 comments · Fixed by #64394
Labels
[Block] Embed Affects the Embed Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@simison
Copy link
Member

simison commented Aug 9, 2024

Some blocks, like audio and image, allow toggling captions on/off via the block toolbar:

Screenshot 2024-08-09 at 09 46 46 Screenshot 2024-08-09 at 09 47 02

Meanwhile, embed blocks always have a caption visible with a placeholder nudge to "add caption" when selected:

Screenshot 2024-08-09 at 09 46 17
Screen.Recording.2024-08-09.at.09.52.07.mov

I'd expect all the media blocks to support captions via the toolbar only, leaving the canvas clean when switching between blocks, less content-jumping when selecting blocks, and better overall consistency.

@simison simison added the [Block] Embed Affects the Embed Block label Aug 9, 2024
@aaronrobertshaw aaronrobertshaw added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement. labels Aug 9, 2024
@hbhalodia
Copy link
Contributor

Hi @simison, I would like to work on this issue and would raise the PR for the same.

Thank You,

@hbhalodia
Copy link
Contributor

Hi @simison @andrewserong @t-hamano, I have raised the PR to make the embed block consistent as per the issue mentioned - #64394

Thank You,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants