Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Embed blocks: adding captions via toolbar - #64385 #64394

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

hbhalodia
Copy link
Contributor

What?

Why?

  • For consistency, embed block was adding the caption option normally and was visible when we add it, instead we converted to what used in audio, image block. To add the caption via toolbar, making the backend editor consistent across blocks.

How?

  • This PR updates the embed block to use the caption via block toolbar.

Testing Instructions

  1. Open any page/post in editor.
  2. Add the embed block.
  3. You can see now, toolbar has option to add the caption, if you click that you would be able to add the caption making it consistent.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

Screenshot 2024-08-09 at 3 53 44 PM

Copy link

github-actions bot commented Aug 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: simison <simison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Embed Affects the Embed Block labels Aug 9, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • The caption still works as before
  • If blocks are multi-selected, the caption toolbar button is not visible
  • Changing the label makes sense to me

@t-hamano t-hamano linked an issue Aug 13, 2024 that may be closed by this pull request
@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Aug 13, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Aug 13, 2024
@t-hamano t-hamano merged commit 943b72a into WordPress:trunk Aug 13, 2024
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 13, 2024
getdave pushed a commit that referenced this pull request Aug 14, 2024
* Add the Caption component to be used for consistency on the embed block similar to audio and image

* Change the label for the embed caption text

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: simison <simison@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed blocks: adding captions via toolbar
4 participants