Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ability to copy and delete patterns in zoom out #66287

Closed
annezazu opened this issue Oct 21, 2024 · 6 comments · Fixed by #66311 or #67279
Closed

Restore ability to copy and delete patterns in zoom out #66287

annezazu opened this issue Oct 21, 2024 · 6 comments · Fixed by #66311 or #67279
Assignees
@draganescu @getdave
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Now that we reverted the vertical toolbar and have returned to the regular toolbar, some of us were testing zoom out today and noticed that we missed having a quick "trash" option. Without it, it's not exactly clear how to remove a pattern, even though using the delete key on the keyboard does still remove the pattern. Considering the prior vertical toolbar included a trash button, I'm marking this as a bug.
@annezazu annezazu added [Feature] Zoom Out Needs Design Feedback Needs general design feedback. labels Oct 21, 2024
@ellatrix ellatrix mentioned this issue Oct 21, 2024
Closed
@ellatrix
Copy link
Member

Fixed here: #66288.

@annezazu
Copy link
Contributor Author

As a quick update -- we can also just add in the three dot menu with perhaps just duplicate and delete as the remaining options.

@annezazu annezazu mentioned this issue Oct 22, 2024
Merged
@ndiego ndiego linked a pull request Oct 22, 2024 that will close this issue
[6.7] Zoom-out (contentOnly): show more menu in block toolbar #66311
Merged
@ndiego ndiego added [Type] Bug An existing feature does not function as intended and removed Needs Design Feedback Needs general design feedback. labels Oct 22, 2024
@ndiego ndiego moved this from 🗣️ In Discussion / Needs Decision to 🏗️ In Progress in WordPress 6.7 Editor Tasks Oct 22, 2024
@getdave getdave changed the title Zoom out: add a delete button to regular toolbar Zoom out: restore ability to delete sections Oct 24, 2024
@getdave getdave mentioned this issue Oct 24, 2024
Open
17 tasks
@getdave
Copy link
Contributor

getdave commented Oct 25, 2024

Noting that #66311 should be the right fix for this, avoiding any more proprietary UI.

@getdave
Copy link
Contributor

getdave commented Nov 4, 2024

This should have been closed in #66311

@getdave getdave closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.7 Editor Tasks Nov 4, 2024
@richtabor richtabor changed the title Zoom out: restore ability to delete sections Restore ability to copy and delete patterns in zoom out Nov 8, 2024
@richtabor
Copy link
Member

This should have been closed in #66311

Re-opening as this was only merged in 6-7, not trunk.

@richtabor richtabor reopened this Nov 8, 2024
@richtabor richtabor reopened this Nov 8, 2024
@draganescu
Copy link
Contributor

It seems in trunk the more menu is there when zoomed out:

Image

but in 6.7.1 the menu is trimmed to less options

Image

@draganescu draganescu mentioned this issue Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

@getdave getdave

Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
6 participants
@draganescu @getdave @richtabor @ellatrix @ndiego @annezazu