Zoom out: restore trash button #66288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 21, 2024
youknowriad
reviewed
Oct 21, 2024
| <BlockSettingsMenu clientIds={ blockClientIds } /> | ||
| { ! isZoomOutMode && ( | ||
| <BlockSettingsMenu clientIds={ blockClientIds } /> | ||
| ) } |
There was a problem hiding this comment.
Personally I wonder if we should instead keep the blockSettingsMenu and try to figure why the default "trash" button is not visible there instead of forking the experience in zoom-out.
There was a problem hiding this comment.
The default delete button is there:
There was a problem hiding this comment.
It's probably that all the other buttons should be removed, so that Delete is the only thing left, is which case the more toggle shouldn't be there?
There was a problem hiding this comment.
Why would we want to remove "duplicate" for instance?
Also, if we want to remove the dropdown if there's only one button, should this behavior be built-in into the toolbar or specific to zoom-out?
There was a problem hiding this comment.
Anyway, I don't mind the current PR but I would like us to remove from special cases and if conditions as much as possible.
draganescu
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
I too am not sure if this is what we want.
In trunk currently we have the block settings icon that has a delete option, but also some other options:
In the 6.7 branch we have nothing, not the trash button nor the block settings button:
In this PR we remove the settings button and replace it with a trash can:
The block settings menu contain items that are a bit weird when zoomed out:
- group affects shuffling, because we lose the category metadata so no more shuffling
- ungroup destroys the pattern and also can result in a completely borked layout
- create pattern is again a weird action when you just added a pattern
- duplicate is useful
- delte is useful
I personally am in favor of removing the settings menu and adding the trash can because zoomed out view is an overview state where drilling through menus removes from the benefit.
richtabor
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Personally I wonder if we should instead keep the blockSettingsMenu and try to figure why the default "trash" button is not visible there instead of forking the experience in zoom-out.
I think it's fine keeping the blockSettingsMenu as well. We do need to tweak the contents when zoomed out thought, to allow copy/duplicate/etc.
|
@richtabor Ok, closing in favour of #66311 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66287.
This button was removed in #66200, and it restored the triple dots "more" menu.
This PR tries to restore the trash button and again remove the "more" menu.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast