Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Mode: Non-overridden synced pattern content is editable #66424

Closed
3 of 6 tasks
talldan opened this issue Oct 24, 2024 · 0 comments · Fixed by #67026
Closed
3 of 6 tasks

Write Mode: Non-overridden synced pattern content is editable #66424

talldan opened this issue Oct 24, 2024 · 0 comments · Fixed by #67026
Assignees
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Write mode [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Oct 24, 2024

Description

(This is the issue that the PR #65408 was intended to solve, but it was reverted due to a performance issue)

Usually synced pattern content is only editable when a block has pattern overrides enabled.

In Write Mode though, all pattern content is editable regardless of overrides.

The bug happens because the getBlockEditingMode changes the editing mode of pattern inner blocks when in Write Mode, whereas usually the pattern block sets the editing of its inner blocks mode itself.

Step-by-step reproduction instructions

  1. Insert a synced pattern with a mixture of overridden an non-overridden content blocks
  2. Try editing various blocks
  3. Observe that non-overridden blocks can't be edited
  4. Enable Write Mode
  5. Now observe that non-overriden blocks can be edited

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Write mode [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant