[Pattern Overrides] Only set block editing mode on first load #59229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Performance
|
Size Change: +79 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
enhancement/pattern-perf
branch
from
6f53cc9
to
a54ba6c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in a54ba6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8013753070
|
There was a problem hiding this comment.
Thanks for the focus on performance @kevin940726 👍
The changes make sense to me but I think after quite a while away from pattern overrides I'll need more detailed test instructions to make sure I'm adequately smoke testing this vs trunk.
Any chance you could flesh out those test instructions a little more, then I can help get this one approved? 🙏
Oops, yeah, I could provide some more context there. This PR doesn't change functionality so the pattern overrides feature should stay the same. I don't have a specific testing structure for this PR, other than what the e2e tests already covered. I guess the manual instructions in #53705 (comment) still apply here though! 🙏 |
|
Given that RC1 is today, I'm removing this from 6.5 as non essential. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A small performance improvement for pattern overrides.
Why?
The original code calls
setBlockEditingModemultiple times whenever the pattern updates. It'll trigger the subscribers forblock-editormultiple times which can be a problem later on for large patterns.How?
Since synced patterns are "locked", we only have to set the editing mode once on the first load (and whenever the editing mode of the pattern itself changes.)
This could be improved when we allow adding blocks in the patterns though.
Testing Instructions
Everything should work correctly as on trunk and CI should pass.
Screenshots or screencast
N/A