-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Block doesn't work when inserting YouTube URL #6824
Comments
This seems like a reasonable assumption to me. |
Related #5241 |
+1 from me! It's literally the first thing I tried to do with it whilst testing in #8299. |
+1 here too! Noting feedback from #5671 which I closed as a duplicate:
|
Yes! The refactor in #10958 exposes some of the embed block's URL->block resolution code, so the video block would be able to use that to resolve the URL to an appropriate embed block. |
Fix up for review at #11410 |
Thank you both @maddisondesigns for bringing this up and @notnownikki for making the improvement. It's a nice and seemingly obvious UX addition. |
Do we have a similar situation with audio blocks?
…On Sun, 4 Nov 2018, 18:22 Matias Ventura ***@***.*** wrote:
Thank you both @maddisondesigns <https://github.com/maddisondesigns> for
bringing this up and @notnownikki <https://github.com/notnownikki> for
making the improvement. It's a nice and seemingly obvious UX addition.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6824 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADKSsoK8BU-aJFQgxLdcvsysdMgTadP_ks5urzB5gaJpZM4UEkrV>
.
|
i have the same issue. The console says cross origin read blocking. How can this be fixed? |
Describe the bug
I wanted to insert a video on my page. The Video Block prompts me to "Enter URL of video here...", so I pasted in the YouTube URL for a vid. After saving the page and checking the front-end, the video didn't appear. I then went back to the editor and noticed the Use URL button so I clicked that but the block just produced an error.
People are going to expect to be able to be able to insert YouTube vids into a block that is specifically called a Video Block.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I should be able to paste YouTube/Vimeo URLS into a block that's called a Video Block
Screenshots
macOS Sierra 10.12.1 (16B2659)
Firefox Quantum 60.0 (64-bit)
WordPress 4.9.6
Gutenberg 2.8.0
The text was updated successfully, but these errors were encountered: