Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more URLs in link handler #732

Closed
jasmussen opened this issue May 9, 2017 · 5 comments
Closed

Allow more URLs in link handler #732

jasmussen opened this issue May 9, 2017 · 5 comments
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. [Type] Question Questions about the design or development of the editor.
Milestone
Merge: Editor

Comments

@jasmussen
Copy link
Contributor

Right now our link filter is pretty strict about there being an actual link there. We should probably relax this a bit so at least you can insert a simple # anchor link.
@jasmussen jasmussen added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Question Questions about the design or development of the editor. labels May 9, 2017
@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@jasmussen jasmussen removed this from the May Week 4: Beta milestone May 22, 2017
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label May 22, 2017
@aduth aduth added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 26, 2017
@jasmussen
Copy link
Contributor Author

Screenshot:

screen shot 2017-08-18 at 09 55 14

@mtias mtias modified the milestones: Beta 1.2, Beta, Needs to happen Aug 31, 2017
@tfrommen
Copy link
Member

tfrommen commented Oct 2, 2017

What exactly should be allowed here?
Everything that can be URI-encoded, which is basically everything?
Only valid (partial) URIs?
Only absolute links as well as (relative) anchor links? What about relative links (e.g., /contact) then?

@jasmussen
Copy link
Contributor Author

What exactly should be allowed here?

WordPress currently allows anything. And since you could potentially have a specialized theme that allowed modern JS like "routes" like contact without any slashes, it seems like we should in fact allow anything.

@tfrommen
Copy link
Member

tfrommen commented Oct 3, 2017

Alright then. I will take care of that.

tfrommen added a commit to tfrommen/gutenberg that referenced this issue Oct 4, 2017
@tfrommen
Make URL input actually a plain text input. WordPress#732
fd49372
aduth added a commit that referenced this issue Oct 4, 2017
@aduth
Merge pull request #2870 from tfrommen/issue/732_link_handler
b7f61d2 
Make URL input actually a plain text input. #732
@mtias
Copy link
Member

mtias commented Oct 10, 2017

Closed by #2870.

@mtias mtias closed this as completed Oct 10, 2017
@yaseenaljamal yaseenaljamal mentioned this issue Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. [Type] Question Questions about the design or development of the editor.
Projects
None yet
Milestone
Merge: Editor
Development

No branches or pull requests
5 participants
@karmatosed @mtias @jasmussen @aduth @tfrommen