Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pre-Publish Panel for Tags and Post Format #7426

Closed
mtias opened this issue Jun 21, 2018 · 8 comments
Closed

Use Pre-Publish Panel for Tags and Post Format #7426

mtias opened this issue Jun 21, 2018 · 8 comments
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Jun 21, 2018

One of the points of the pre-publish panel was to surface things you might have missed to do before publishing. The panel is already extensible so plugins can make use of it.

It'd be nice to also use it for the following simple cases:

  • When detecting a post format suggestion (based on the block configuration) expose the suggestion here.
  • When detecting no tags have been added, render the tags module in the panel.
@gziolo gziolo added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Jun 21, 2018
@gziolo
Copy link
Member

gziolo commented Jun 21, 2018

We discussed in the past that it would be nice to add call for action which disables the publish button until some criteria are met. Should it be included in this issue or should we open another one?

@adamsilverstein
Copy link
Member

I have this related issue open - #7020

@sarahmonster
Copy link
Member

Some general improvements I think we could make with this panel, before diving in here:

I've filed these all as separate issues (with PRs, for the most part), but I think they'll all go toward improving the overall publishing flow in #7602 and I've used them as a baseline for my approach here as well.

Because this panel is extensible and potentially will be made use of by plugins, it probably makes sense to keep any additional checks here relatively simple.

One approach would be to follow the existing pattern of pull-down sections:

screenshot 2018-07-10 21 14 38

I think this could confuse people if these panels would display in some situations, but not in others. It may help to make things more obvious if we were to use alerty icons instead:

screenshot 2018-07-10 21 28 20

...but I could see that inducing a bit of unnecessary panic in people. 😜

Instead, it may make sense to make the prompt a bit more conversational when it appears—less a warning, and more a gentle attempt to help users get the most mileage out of their post:

screenshot 2018-07-10 22 23 45

@tofumatt
Copy link
Member

The lightbulb/tip notion is aces.

Only thing to add is it'd be really great to see a "don't show this again–just publish my post next time" option, as I find this panel just gets in my way–when I click "publish" I just want my post to go live. WordPress.com's editor has a similar checkbox; we should have one too.

@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Enhancement A suggestion for improvement. labels Jul 19, 2018
@oandregal
Copy link
Member

I've started working on tag suggestions within the PrePublishPanel at #8235

@chrisvanpatten
Copy link
Contributor

It would be really nice if these tips could be disabled, modified, or added to as well. I think it's fair for Gutenberg to try to make some general recommendations, but more complex/unique sites may have other use-cases that conflict with the general recommendations.

@oandregal
Copy link
Member

#8235 also includes the PostFormat now.

@sarahmonster
Copy link
Member

This issue was closed some time ago via #8235; feel free to re-open if there's any remaining actionable to-dos here! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

7 participants