Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-publish panel calendar and timepicker are misaligned at certain breakpoints #7863

Closed
sarahmonster opened this issue Jul 10, 2018 · 0 comments · Fixed by #7864
Closed
Assignees
Labels
[Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended

Comments

@sarahmonster
Copy link
Member

Issue Overview

In the pre-publish panel, the calendar is left-aligned, whilst the timepicker below it is centre-aligned. This works at the majority of viewports where the sidebar is a controlled width overall, but falls apart at those viewports where the sidebar ends up being the full width of the screen:

screenshot 2018-07-09 20 23 47

Steps to Reproduce

  1. Set your browser width between 320 and 778 pixels. (Approximately.)
  2. Start a new post and add a title.
  3. Press publish.
  4. Click on the "Publish" panel to open the datepicker.
  5. See misalignment!

This issue doesn't seem to happen elsewhere—the only other usage of the calendar component I could find was in the document settings sidebar, where the calendar appears as a popup instead:

screenshot 2018-07-10 13 01 24

Possible Solution

Basically, this would be resolved either by setting a max-width on the timepicker, or left-aligning the timepicker. The former is more elegant and in line with the calendar component as used elsewhere, but does rely on the calendar retaining a set width.

@sarahmonster sarahmonster self-assigned this Jul 10, 2018
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Jul 10, 2018
@mtias mtias added [Feature] Document Settings Document settings experience and removed [Feature] UI Components Impacts or related to the UI component system labels Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants