Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use gettext/code inside markup string (eg PreviewButton's "Please wait") #7725

Closed
tofumatt opened this issue Jul 5, 2018 · 2 comments
Closed

Add ability to use gettext/code inside markup string (eg PreviewButton's "Please wait") #7725

tofumatt opened this issue Jul 5, 2018 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Code Quality Issues or PRs that relate to code quality

Comments

@tofumatt
Copy link
Member

tofumatt commented Jul 5, 2018 •
edited
Loading

As mentioned in #3301, PreviewButton has untranslated strings (https://github.com/WordPress/gutenberg/blob/master/editor/components/post-preview-button/index.js#L75), but we can't just put __() in there because we don't have React escaping.

https://github.com/WordPress/gutenberg/pull/3301/files#r148514197
@tofumatt tofumatt added Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Code Quality Issues or PRs that relate to code quality labels Jul 5, 2018
@tofumatt tofumatt mentioned this issue Jul 5, 2018
Closed
@Soean Soean mentioned this issue Oct 15, 2018
Closed
@ocean90 ocean90 mentioned this issue Oct 21, 2018
Closed
@swissspidy swissspidy mentioned this issue Oct 21, 2018
Merged
4 tasks
@jasmussen jasmussen mentioned this issue Oct 22, 2018
Merged
@noisysocks
Copy link
Member

Using Lodash's escape utility should be fine for this.

- <p>Please wait&hellip;</p>
+ ${ escape( __( 'Please wait…' ) ) }

@noisysocks noisysocks added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 23, 2018
@swissspidy
Copy link
Member

Note that there's an existing PR: #10880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tofumatt @noisysocks @swissspidy